Extra inline func in new global new/delete impls causing problems

VERIFIED FIXED

Status

VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: treilly, Assigned: treilly)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 397300 [details] [diff] [review]
goes back to what it was like before
Attachment #397300 - Flags: superreview?(lhansen)

Updated

10 years ago
Attachment #397300 - Flags: superreview?(lhansen) → superreview+

Comment 1

10 years ago
Comment on attachment 397300 [details] [diff] [review]
goes back to what it was like before

Indeed, I doubt very much I would have approved the change to add inline functions in the global operators in the first place.  The whole point of the recent fix introducing OutOfLineAlloc was to control code size bloat; why was there a change here?
(Assignee)

Comment 2

10 years ago
Well if the AllocCallInline was inlined like we asked it to be then new would have expanded to a call to OutOfLineAlloc.  I was just trying to avoid redundancy, should have used macros.
(Assignee)

Comment 3

10 years ago
changeset 2454
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

10 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.