513342 - crash while browsing to and from a geolocation page

Status: VERIFIED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8) (PTO'ish until July 5)]

I do this:
1) browse to www.mozilla.org
2) browse to http://people.mozilla.com/~jmaher/wifi_text.html
3) click "share"
4) observe your geolocation data
6) browse to m.cnn.com
7) hit the back button 3 times 
   * observe you get a new geolocation notification bar
8) now that you are back at mozilla.org, hit the forward button
9) click "share" in the geolocation notification prompt
10) observe the crash


this is with 20090828 respin of 1.9.2 alpha3 rc for winmo

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

be more careful about nulling stuff out when you freelibrary.

Comment 2

[Doug Turner (:dougt)]

the maemo stuff should have been removed in another bug.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 397713 [details] [diff] [review]
patch v.1

ignore whitespace.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 397713 [details] [diff] [review]
patch v.1


>-WinMobileLocationProvider::WinMobileLocationProvider():
>-mGPSDevice(nsnull), mHasSeenLocation(PR_FALSE)
>+WinMobileLocationProvider::WinMobileLocationProvider()
>+: mGPSDevice(nsnull), 
nit, move ':' up one line


> NS_IMETHODIMP WinMobileLocationProvider::Startup()
> {
>-  if (!mGPSDevice) {
>+  if (!mGPSInst) {
>     mGPSInst = LoadLibraryW(L"gpsapi.dll");

do all devices have this dll?  If not, we should probably not try to open it repeatedly  

>   
>   if (mGPSDevice)
>     mCloseDevice(mGPSDevice);
>+
>+  mGPSDevice = nsnull;
>   
is it possible for mGPSDevice to be non null with mCloseDevice null?  I don't think so, but wanted to ask.

>-
>-  // if NS_MAEMO_LOCATION, see if we should try the MAEMO location provider
>-#ifdef NS_MAEMO_LOCATION
>-  provider = new MaemoLocationProvider();
>-  if (provider)
>-    mProviders.AppendObject(provider);
>-#endif

Why are you removing this?

Comment 5

[Doug Turner (:dougt)]

> Why are you removing this?

We removed the Maemo provider a while ago but I forgot to remove this part.

Comment 6

[Doug Turner (:dougt)]

Attachment: patch v.2

Comment 7

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/56e80a2070a6

Comment 8

[Doug Turner (:dougt)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/826f98f8af26

Comment 9

[Steffen Wilberg]

status1.9.2 = beta-1-fixed per comment 8.

Comment 10

[Aakash Desai [:aakashd]]

verified FIXED On build:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2b1pre) Gecko/20090923 Fennec/1.0a3