513352 - Clicking on Design challenge(id=6) throws a page not found error

Status: VERIFIED FIXED

(Websites :: creative.mozilla.org, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1.go to http://mcc.stage.mozilla.com/challenges
2.Click on the design challenge-"this is a test"

expected results:
Loads the designer winner details for that challenge

actual result:page not found error
Is this caused by error in the challenge details?

screenshot: http://screencast.com/t/FLECA9IVKo11

Comment 1

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

That's being caused by Design 5 being an an ID# for an invalid design.  

I'm catching this and not displaying invalid designs that have been added.

I'm also sending an error message to the admin to fix the invalid Design, whether its an invalid Design ID or a Design ID associated with a Design that has not been added to this design challenge.

==

Sending        application/controllers/admin.php
Sending        application/i18n/en_US/admin.php
Sending        application/models/design.php
Sending        application/views/admin/admin_challenges.php
Sending        application/views/challenges/challenges_view_not_current.php
Transmitting file data .....
Committed revision 50440.




Sending        application/controllers/admin.php
Sending        application/i18n/en_US/admin.php
Sending        application/models/design.php
Sending        application/views/admin/admin_challenges.php
Sending        application/views/challenges/challenges_view_not_current.php
Transmitting file data .....
Committed revision 50440.

Comment 2

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Adding one more fix, which will allow invalid Design IDs to be saved in the winning designs area, but will not allow valid Design IDs to be saved if the design was not submitted to the contest.

It's tough to explain, but basically, I'm making sure that designs that were not submitted to the challenge will not display on the challenge page.  I'm also making sure that designs that became a challenge winner at one time will not be lost upon save.  The former challenge winners that have been removed by an admin or a user do not display on the challenge page.

==

Sending        application/controllers/admin.php
Transmitting file data .
Committed revision 50443.

Comment 3

[krupa raj[:krupa]]

looks fixed