Closed Bug 513366 Opened 15 years ago Closed 15 years ago

Certain test cases depend on exact method_id in the toString() text for Function objects

Categories

(Tamarin Graveyard :: Tools, defect)

Product:
Tamarin Graveyard
Component:
Tools
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: stan, Assigned: brbaker)

Details

Attachments

(2 obsolete files)

User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.12) Gecko/2009070609 Firefox/3.0.12 Build Identifier: The number in the toString() text for Function happens to be the method_id (pool index) but this is not something that can or should be assumed. For instance, the GlobalOptimizer reorders the method pool. Test cases: ecma3/FunctionObjects/e15_3_2_1_1_rt.as ecma3/String/e15_5_4_9_1_rt.as Reproducible: Didn't try Steps to Reproduce: Run the Global Optimizer on test cases. Tests can fail because the methods are reordered on the ABC, but they should not.
Attached file Patch (obsolete) —
Perforce changelist 570795
Please auto-submit this patch if approved. Thx.
Attached patch testcase patch (obsolete) — — Splinter Review
ecma3/String/e15_5_4_9_1_rt.as was already patched in changeset 1819:4013f0557b21 back on 05/01/09
Attachment #397366 - Attachment is obsolete: true
Attachment #397868 - Flags: review?(dschaffe)
Assignee: nobody → brbaker
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: in-testsuite+
Flags: flashplayer-triage+
Flags: flashplayer-qrb+
Attachment #397868 - Flags: review?(dschaffe) → review+
Comment on attachment 397868 [details] [diff] [review] testcase patch Pushed patch as 2415:4cfb189b02c3
Attachment #397868 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: