TM: Inline GetUnitString fast path

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: gal, Assigned: gal)

Tracking

Trunk
x86
Mac OS X
Points:
---
Bug Flags:
wanted1.9.2 +

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
5% speedup for string-base64
(Assignee)

Comment 1

9 years ago
Created attachment 397370 [details] [diff] [review]
patch
Assignee: general → gal

Updated

9 years ago
Attachment #397370 - Flags: review+
Top-level function definitions have name starting in col. 1, and left brace under that first char of name on the next line.

/be

Comment 3

9 years ago
ug, sorry, those formatting bugs should have been obvious. even to me.
(Assignee)

Comment 4

9 years ago
No problem. I will do a patch on top of this to make unit string creation less lazy and speed up String[index].
https://bugzilla.mozilla.org/show_bug.cgi?id=491170 might be of interest, or might not.  I was talked out of continuing it because of the memory effects, though that's not in the bug.  Glad to be un-talked-out-of-it!
http://hg.mozilla.org/mozilla-central/rev/37771fe15220 (I think this is fixed, gal, please reopen if you planned to use this bug for comment 4).
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

9 years ago
#4 was solved in a separate bug by gregor wagner

Comment 8

9 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/0df22365796b
status1.9.2: --- → beta1-fixed
Flags: wanted1.9.2+
You need to log in before you can comment on or make changes to this bug.