Closed
Bug 513373
Opened 16 years ago
Closed 16 years ago
TM: Inline GetUnitString fast path
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | beta1-fixed |
People
(Reporter: gal, Assigned: gal)
Details
Attachments
(1 file)
|
14.18 KB,
patch
|
sayrer
:
review+
|
Details | Diff | Splinter Review |
5% speedup for string-base64
|
Assignee | |
Comment 1•16 years ago
|
||
Assignee: general → gal
|
||
Updated•16 years ago
|
Attachment #397370 -
Flags: review+
|
|
||
Comment 2•16 years ago
|
||
Top-level function definitions have name starting in col. 1, and left brace under that first char of name on the next line.
/be
|
|
||
Comment 3•16 years ago
|
||
ug, sorry, those formatting bugs should have been obvious. even to me.
|
|
Assignee | |
Comment 4•16 years ago
|
||
No problem. I will do a patch on top of this to make unit string creation less lazy and speed up String[index].
|
||
Comment 5•16 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=491170 might be of interest, or might not. I was talked out of continuing it because of the memory effects, though that's not in the bug. Glad to be un-talked-out-of-it!
|
||
Comment 6•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/37771fe15220 (I think this is fixed, gal, please reopen if you planned to use this bug for comment 4).
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 7•16 years ago
|
||
#4 was solved in a separate bug by gregor wagner
|
|
||
Comment 8•16 years ago
|
||
status1.9.2:
--- → beta1-fixed
Flags: wanted1.9.2+
You need to log in
before you can comment on or make changes to this bug.
Description
•