513392 - Use styles on the normal icon rather than a separate hardcoded image for plugin icons

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

Attachment: patch rev 1

There isn't any need for a separate image element for plugins.

Comment 1

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/64da35bd0d16

Comment 2

[Dão Gottwald [:dao]]

This doesn't seem to work, because of iconURL="chrome://mozapps/skin/xpinstall/xpinstallItemGeneric.png", which ends up as src="chrome://mozapps/skin/xpinstall/xpinstallItemGeneric.png" on the image, which overrides the list-style-image.

Comment 3

[Dave Townsend [:mossop]]

Yeah, it broke with the followup fix to bug 511091, but I have a fix for it almost ready.

Comment 4

[Dave Townsend [:mossop]]

Attachment: follow-up fix

The extension manager datasource is returning icons for items it doesn't actually know about. If the item isn't downloading and doesn't have an install location then it is unknown and it we shouldn't return any icon for it.

Comment 5

[Dave Townsend [:mossop]]

Landed the followup: http://hg.mozilla.org/mozilla-central/rev/ecb355c31e14

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 397400 [details] [diff] [review]
patch rev 1

Simple fix and its followup. The lightweight themes patch relies on this somewhat and it makes things easier for theme authors too.

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 399431 [details] [diff] [review]
follow-up fix

Need this fix too

Comment 8

[Dave Townsend [:mossop]]

Landed on branch:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/262a00043288
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/76bca9182766

Comment 9

[Dão Gottwald [:dao]]

At this point this means final-fixed, I think.