Closed Bug 513436 Opened 10 years ago Closed 10 years ago

TM: Inline js_DoubleToInteger

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: gal, Assigned: gal)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

If we don't, gcc seems to fail to inline isfinite, which seriously hurts.
Attached patch patchSplinter Review
Assignee: general → gal
Attachment #397438 - Flags: review?(sayrer)
Comment on attachment 397438 [details] [diff] [review]
patch

looks like JSBool neg can be declared when first used.
Attachment #397438 - Flags: review?(sayrer) → review+
http://hg.mozilla.org/tracemonkey/rev/d8a9a1803ea5
Whiteboard: fixed-in-tracemonkey
so, we did this because gcc won't inline floor and isfinite unless this function is inlined too, making for lots of time spent in function prologues and epilogues.
http://hg.mozilla.org/mozilla-central/rev/d8a9a1803ea5
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.