Closed
Bug 513436
Opened 16 years ago
Closed 16 years ago
TM: Inline js_DoubleToInteger
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | beta1-fixed |
People
(Reporter: gal, Assigned: gal)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
1.87 KB,
patch
|
sayrer
:
review+
|
Details | Diff | Splinter Review |
If we don't, gcc seems to fail to inline isfinite, which seriously hurts.
|
Assignee | |
Comment 1•16 years ago
|
||
Assignee: general → gal
Attachment #397438 -
Flags: review?(sayrer)
|
||
Comment 2•16 years ago
|
||
Comment on attachment 397438 [details] [diff] [review]
patch
looks like JSBool neg can be declared when first used.
Attachment #397438 -
Flags: review?(sayrer) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
|
||
Comment 4•16 years ago
|
||
so, we did this because gcc won't inline floor and isfinite unless this function is inlined too, making for lots of time spent in function prologues and epilogues.
|
||
Comment 5•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•16 years ago
|
||
status1.9.2:
--- → beta1-fixed
Flags: wanted1.9.2+
You need to log in
before you can comment on or make changes to this bug.
Description
•