XSLT Doesnt compile under Win2K

VERIFIED FIXED

Status

()

Core
XSLT
P3
major
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: Jus, Assigned: Nisheeth Ranjan)

Tracking

Trunk
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
After defining MOZ_XSL the lizard wont build completely. I have a fixe for the
faults in my tree, however loading test.xml out of the examples causes an
Assertion with XMLDOMUtils::copyNode() due to an illegal Namespace anyway (Ill
raise a bug with details tomorrow, Must sleep)

Anyway, here is the error and its fix to allow it to be built:
1) layout/base/src/Makefile.win + layout/base/public/Makefile.win  need to
define MOZ_XSL.
  Fix:   MOZ_XSL should be defined in /config/config.mak the same as MOZ_SVG and
MOZ_MATHML are. This would make MOZ_XSL globably defined for all Makefile.win's

Can someone with a big stick get this made!
(Reporter)

Comment 1

18 years ago
Changed Severity back to Major as it only screws windows. Wasnt sure of the
policy for bug severity for non-default/nighlty components. :)
Severity: blocker → major

Comment 2

18 years ago
This has been discussed before, and I obey the orders from the mighty build
gods. Not clutter the tree with DEFINES. As we want to remove MOZ_XSL from
layout alltogether, this should go into the makefile.wins.

Will attach corresponding patch, confirming, adding nisheeth.
Nisheeth, could you review the patch I'll attach? Thanx.

Grabbing the bug.

Axel
Assignee: kvisco → axel
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 3

18 years ago
Created attachment 14027 [details] [diff] [review]
patch to layout/base/[base|public]/makefile.win

Updated

18 years ago
Blocks: 42228

Comment 4

18 years ago
Reassigning to nisheeth, to get the review on his instead of my buglist.

Axel
Assignee: axel → nisheeth

Comment 5

18 years ago
XSLT hooks are on in default build, and it compiles on Windows 2000.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 6

18 years ago
Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.