513466 - nsPlacesDBFlush doesn't implement nsINavHistoryObserver::onBeforeDeleteURI

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Nickolay_Ponomarev]

Attachment: trivial fix

nsPlacesDBFlush doesn't implement nsINavHistoryObserver::onBeforeDeleteURI causing the following error when deleting a URI from history:

* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'JavaScript component does not have a method named: "onBeforeDeleteURI"' when calling method: [nsINavHistoryObserver::onBeforeDeleteURI]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "JS frame :: file:///Users/nickolay/dev/mozilla-work/src/obj-ff-debug/dist/MinefieldDebug.app/Contents/MacOS/components/nsPlacesAutoComplete.js :: PAC_onValueRemoved :: line 457"  data: no]

Comment 1

[Shawn Wilsher :sdwilsh]

Comment on attachment 397452 [details] [diff] [review]
trivial fix

Oh thank you thank you thank you.  I kept seeing this error but had no clue what observer didn't implement it.

r=sdwilsh

Comment 2

[Nickolay_Ponomarev]

http://hg.mozilla.org/mozilla-central/rev/fc2134fff83b

Comment 3

[[e-mail]]

Would this be at least wanted on all branches that have nsPlacesDBFlush?

Comment 4

[Shawn Wilsher :sdwilsh]

(In reply to comment #3)
> Would this be at least wanted on all branches that have nsPlacesDBFlush?
Likely

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 397452 [details] [diff] [review]
trivial fix

asking approval, trivial change with no risk. to avoid polluting errors.

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/33d673da0acb