Closed Bug 513466 Opened 14 years ago Closed 14 years ago

nsPlacesDBFlush doesn't implement nsINavHistoryObserver::onBeforeDeleteURI

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: asqueella, Assigned: asqueella)

References

Details

Attachments

(1 file)

trivial fix
995 bytes, patch
sdwilsh
: review+
dietrich
: approval1.9.2+
Details | Diff | Splinter Review
Attached patch trivial fix — — Splinter Review 
nsPlacesDBFlush doesn't implement nsINavHistoryObserver::onBeforeDeleteURI causing the following error when deleting a URI from history:

* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'JavaScript component does not have a method named: "onBeforeDeleteURI"' when calling method: [nsINavHistoryObserver::onBeforeDeleteURI]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "JS frame :: file:///Users/nickolay/dev/mozilla-work/src/obj-ff-debug/dist/MinefieldDebug.app/Contents/MacOS/components/nsPlacesAutoComplete.js :: PAC_onValueRemoved :: line 457"  data: no]
Attachment #397452 - Flags: review?(sdwilsh)
Comment on attachment 397452 [details] [diff] [review]
trivial fix

Oh thank you thank you thank you.  I kept seeing this error but had no clue what observer didn't implement it.

r=sdwilsh
Attachment #397452 - Flags: review?(sdwilsh) → review+
http://hg.mozilla.org/mozilla-central/rev/fc2134fff83b
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Would this be at least wanted on all branches that have nsPlacesDBFlush?
(In reply to comment #3)
> Would this be at least wanted on all branches that have nsPlacesDBFlush?
Likely
Comment on attachment 397452 [details] [diff] [review]
trivial fix

asking approval, trivial change with no risk. to avoid polluting errors.
Attachment #397452 - Flags: approval1.9.2?
Attachment #397452 - Flags: approval1.9.2? → approval1.9.2+
Keywords: checkin-needed
Whiteboard: [1.9.2 landing needed]
You need to log in before you can comment on or make changes to this bug.