513469 - Don't use nsIBrowserInstance in Firefox

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Nickolay_Ponomarev]

From the now-closed bug 46200:

-------  Comment #102 From  Nickolay_Ponomarev   2009-07-18 12:09:10 PDT
So...

http://mxr.mozilla.org/mozilla-central/search?string=nsibrowserinstance and
http://mxr.mozilla.org/mozilla-central/search?string=component/browser/instance
only list the interface/component used in (Firefox's) browser.js

In browser.js the component is created only once and stored in a global
variable appCore. http://mxr.mozilla.org/mozilla-central/search?string=appCore
shows this variable is only used in browser.js:
# line 924 -- appCore.startPageCycler();
-- #ifdef'ed ENABLE_PAGE_CYCLER -- I don't see this being defined anywhere.
Plus anyway  nsBrowserInstance::StartPageCycler is a no-op.

# line 1107 -- appCore =
Components.classes["@mozilla.org/appshell/component/browser/instance;1"]
# line 1145 -- appCore.setWebShellWindow(window);
-- startup initialization. The component stores references to the chrome
|window| and the content window, but doesn't appear to do anything else useful.
Also has some debug code, which doesn't appear useful.

# line 1433 -- if (appCore)
# line 1434 -- appCore.close();
-- on shutdown. Doesn't do anything useful (sets a flag, which doesn't seem to
affect anything).

Looks like it can be killed. Anything I missed?

------

It should be possible to remove the component and the interface both from Firefox and mozilla-central, but removing it from Firefox requires packaging changes which tend to cause pain and suffering, and removing it from mozilla-central requires fixing up comm-central, which still uses the component.

Removing references to the component from browser.js is easy though, so let's do it first.

Comment 1

[Nickolay_Ponomarev]

Attachment: remove nsIBrowserInstance usage from browser.js

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 397453 [details] [diff] [review]
remove nsIBrowserInstance usage from browser.js

Might even be a nice Ts win!

Comment 3

[Nickolay_Ponomarev]

http://hg.mozilla.org/mozilla-central/rev/0ebc23cbbf14

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 397453 [details] [diff] [review]
remove nsIBrowserInstance usage from browser.js

a192=beltzner (did it turn out to be a Ts win? if so, can someone whiteboard this with [ts]?)

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/43faac8845b6