Closed Bug 513493 Opened 13 years ago Closed 13 years ago

Adjust Unified Toolbar to Match Snow Leopard

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1
Tracking Status
status1.9.2 --- beta4-fixed

People

(Reporter: djspiewak, Assigned: mstange)

Details

Attachments

(7 files, 3 obsolete files)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2

It seems that in Snow Leopard, Apple has slightly adjusted the gradient coloring for the standard unified toolbar.  Specifically, everything is just a shade lighter with a hint of tan.  This means that Firefox's unified toolbar looks a bit out of place when compared to Safari and Finder.  Screenshots to follow.

In keeping with Firefox's track record of visually catering to the latest version of Mac OS X, I propose that the unified toolbar gradient be adjusted in Firefox.next to match the Snow Leopard standard.

Reproducible: Always




Filed as a bug rather than an RFE as this issue is disruptive of Firefox's visual integration with the Mac platform.
Could you also upload screenshots of inactive windows, i.e. with the lighter gradient? Specifically, one screenshot of the inactive Firefox preferences window and one of the inactive Safari preferences window would be most useful.
Assignee: nobody → mstange
Status: UNCONFIRMED → ASSIGNED
Component: Theme → Widget: Cocoa
Ever confirmed: true
Product: Firefox → Core
QA Contact: theme → cocoa
Hardware: x86 → All
Version: unspecified → Trunk
Attached image Unified Toolbar in Safari 4 (inactive) (obsolete) —
Attached image Unified Toolbar in Finder (inactive) (obsolete) —
Requested screenshots now attached
I need to learn to read.  Sorry about the comment spam...
Attachment #397688 - Attachment is obsolete: true
Attachment #397686 - Attachment is obsolete: true
Hi, I'm wondering when we can have these matched to Snow Leopard ?
1. unified toolbar
2. -moz-chrome-active and -moz-chrome-inactive
3. -moz-mac-focusring

And... will this be fixed in Firefox 3.5.*? I'm afraid when we have Firefox 3.6 and 3.7 will be 1 year later, I guess... because they are still in alpha right now:(

Thank you :)
Oh, the focus ring colors have changed, too? Interesting.
I'll create a patch soon.
Attached patch v1 (obsolete) — Splinter Review
Attachment #401772 - Flags: review?(joshmoz)
Comment on attachment 401772 [details] [diff] [review]
v1

new patch coming
Attachment #401772 - Attachment is obsolete: true
Attachment #401772 - Flags: review?(joshmoz)
Attached patch v2Splinter Review
Attachment #402018 - Flags: review?(joshmoz)
Attachment #402018 - Flags: review?(joshmoz) → review+
http://hg.mozilla.org/mozilla-central/rev/9bbef3004ce8
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Attachment #402018 - Flags: approval1.9.2?
Attachment #402018 - Flags: approval1.9.1.4?
Attachment #402018 - Flags: approval1.9.1.4? → approval1.9.1.5?
This really needs to land on 1.9.2 before we take it on 1.9.1.
Attachment #402018 - Flags: approval1.9.2? → approval1.9.2+
This really shouldn't be affecting sunspider.  How is that test being run?
Each sunspider test seems to cause redraws of the stop button, the tab title and the status bar. Maybe these redraws fall in the measured time window?
Since this patch makes us check the OS version every time we draw one of the native grey colors, those draw operations might take a tiny bit longer.
Huh, no, the OS version is cached. Weird.
> Maybe these redraws fall in the measured time window?

They shouldn't, unless something is really wrong in terms of how the test is measured, imo.
Attachment #402018 - Flags: approval1.9.1.6? → approval1.9.1.6-
Comment on attachment 402018 [details] [diff] [review]
v2

Doesn't seem like the kind of fix we have to take on the stable branch. 1.9.1 approval denied.
Removing the Objective C exception guards in OSXVersion() fixes the regression.
We don't make any Objective C calls in that method, so they shouldn't be necessary.
Attachment #413052 - Flags: review?(joshmoz)
Attachment #413052 - Flags: review?(joshmoz) → review+
(In reply to comment #19)
> Each sunspider test seems to cause redraws of the stop button, the tab title
> and the status bar.

Actually, that's wrong. SunSpider is run in a window where all toolbars and the statusbar and tabbar are hidden.
The only thing that's redrawn is the window's title bar when the title changes.
You need to log in before you can comment on or make changes to this bug.