513700 - Backport 1.5 Search API into the regular API

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

We should power the existing 1.2 API with Sphinx.

This will completely remove our dependence on the old Fulltext-based search.

Comment 1

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Attachment: v1

Note: This patch contains bug 504700 as they share a lot of common code.

Comment 2

[Laura Thomson :laura]

Just a couple comments...

You probably meant 1.3 (that's what Fx uses IIRC).  

You should test this against the Add-ons Manager in Firefox, since it relies on
the behavior of this version of the API.  Two things in particular jump out at
me:
- What behavior do you get in the event of a 503? 
- 'all' types for the API means extensions + themes.  I am not sure of the
reason for this off the top of my head but I think it might have been because 
the Add-ons Manager can't install other kinds.  I didn't see support for this
in your patch (although I only ran my eye over it v briefly).

Also cced Mossop for anything I haven't thought of.

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 397745 [details] [diff] [review]
v1

I just saw this patch contains one I already reviewed.  Since that got an r- I'll r- this too.  Please keep patches separate as much as possible.  Thanks.

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Sure.  I do have a problem where a lot of my changes are dependent on one another.  I can just hold off on publishing patches until the first item is fixed.

Thanks

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Attachment: v2

This patch covers 504700 and should address all the issues you outlined in there.

Comment 6

[Wil Clouser [:clouserw]]

Comment on attachment 398226 [details] [diff] [review]
v2

The 60 item hard limit still exists.  Should we file a separate bug?

Comment 7

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

I'll remove that limit, and then commit.

Comment 8

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

------------------------------------------------------------------------
r50757 | [e-mail] | 2009-09-02 16:23:35 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 513700] Fixed an unset index issue.

------------------------------------------------------------------------
r50756 | [e-mail] | 2009-09-02 16:23:33 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 513700] removed 60 hardlimit and increased to 1000

------------------------------------------------------------------------
r50755 | [e-mail] | 2009-09-02 16:23:31 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 513700] Restoring License

------------------------------------------------------------------------
r50754 | [e-mail] | 2009-09-02 16:23:28 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 513700] Restoring License

------------------------------------------------------------------------
r50753 | [e-mail] | 2009-09-02 16:23:24 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 513700] Restoring License

------------------------------------------------------------------------
r50752 | [e-mail] | 2009-09-02 16:23:21 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 513700] Removing sphinx.sql as this is redundant to remora.sql and the sphinx migrations.sql

------------------------------------------------------------------------
r50751 | [e-mail] | 2009-09-02 16:23:19 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 513700] adding author to search

------------------------------------------------------------------------
r50750 | [e-mail] | 2009-09-02 16:23:17 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 513700] Removed a few comments

------------------------------------------------------------------------
r50749 | [e-mail] | 2009-09-02 16:23:14 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 513700] Removing API1.5 as it's just a 1-off controller, that is duplicated in the main controller

------------------------------------------------------------------------
r50748 | [e-mail] | 2009-09-02 16:23:11 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 513700] Adding Sphinx to old API as well, including unit tests to verify that it works

------------------------------------------------------------------------
r50747 | [e-mail] | 2009-09-02 16:23:08 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 504700] Sorts! All sorts of sorting.

------------------------------------------------------------------------
r50746 | [e-mail] | 2009-09-02 16:23:05 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 504700] Migrations code for sphinx

------------------------------------------------------------------------
r50745 | [e-mail] | 2009-09-02 16:23:03 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 504700] Fixed the error message page when searchd is down.

------------------------------------------------------------------------
r50744 | [e-mail] | 2009-09-02 16:22:59 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 504700] Sorts! All sorts of sorting.

------------------------------------------------------------------------
r50743 | [e-mail] | 2009-09-02 16:22:57 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 504700] Debugging for sphinx

------------------------------------------------------------------------
r50742 | [e-mail] | 2009-09-02 16:22:54 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 504700] Migrations code for sphinx

------------------------------------------------------------------------
r50741 | [e-mail] | 2009-09-02 16:22:51 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 504700] Search Frontend is done sans sorting

------------------------------------------------------------------------
r50740 | [e-mail] | 2009-09-02 16:22:48 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 504700] Added addon type search support via Sphinx to FE

------------------------------------------------------------------------
r50739 | [e-mail] | 2009-09-02 16:22:44 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 504700] Added version search support via Sphinx to FE

------------------------------------------------------------------------
r50738 | [e-mail] | 2009-09-02 16:22:42 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 504700] Removing hver from everywhere. We only need to know what version they want.

------------------------------------------------------------------------
r50737 | [e-mail] | 2009-09-02 16:22:38 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 504700] Made the tag searching more forgiving... sort of

------------------------------------------------------------------------
r50736 | [e-mail] | 2009-09-02 16:22:26 -0700 (Wed, 02 Sep 2009) | 2 lines

[bug 504700] Basic searching via sphinx on the frontend

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

https://litmus.mozilla.org/show_test.cgi?id=7845 has just a few Litmus testcases that I'd like help building out -- thanks!