Editors can not see the changes in a build - only approve/deny it

VERIFIED FIXED

Status

--
major
VERIFIED FIXED
9 years ago
4 years ago

People

(Reporter: cbook, Unassigned)

Tracking

Details

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
Created attachment 397678 [details]
screenshot

See screenshot. A Editor can only approve or Reject a release. There is no button to the see the changes for for things like distribution changes etc (like admins have).

I think editors should also see the customizations to determine if a build can get approved.
The list of changes had actually been disabled for everyone, even admins.  I re-enabled it in r50607, with permission checking.  

It's still kind of an unfriendly layout of the information, but it should be visible now.  May need a mockup for it at some point with some thought into how to better present it.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Reporter)

Comment 2

9 years ago
Created attachment 398120 [details]
new screenshot

Les, i think its not fixed. As example when i log in as editor and click on the queue i can only approve/deny a release (see screenshot).

I would expect for a editor that he has something like  
 Preview:      * First-run page     * distribution.ini     * repack.cfg     * repack.log

and not just preview * First-run page 

or do i miss a step here ?
No, the distribution.ini, repack.cfg, and repack.log links are just for admins to troubleshoot / debug the app and build process itself.  They don't really show the changes made to the browser, so editors shouldn't need them.

And the changes section will not appear on the page if there have been no changes between the release and the changes in progress.  So, a URL to the browser you're looking at might help if there's still a problem.

fwiw, I just made some changes to this browser, and I see the Changes section appeared:

http://dm-partnerdist01.mozilla.org:82/~lorchard/byob2/profiles/neilio/browsers/g0NTkxODczMA/unreleased
(Reporter)

Comment 4

9 years ago
ah got it, thanks les !
Status: RESOLVED → VERIFIED
(Assignee)

Updated

4 years ago
Product: Websites → Websites Graveyard
You need to log in before you can comment on or make changes to this bug.