513749 - Mismerge causes issues in animated images

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Joe Drew (not getting mail)]

Attachment: add back braces

In bug 753, I accidentally removed a pair of braces, which causes some problems (at worst, some extra drawing, I think). This patch restores those braces.

Comment 1

[Bobby Holley (:bholley)]

Comment on attachment 397693 [details] [diff] [review]
add back braces

Given the indentation I have trouble really comprehending what we're doing on trunk right now, but this patch certainly looks right. r=bholley

Comment 2

[Joe Drew (not getting mail)]

http://hg.mozilla.org/mozilla-central/rev/a1c45ec0d5d5

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 397693 [details] [diff] [review]
add back braces

This patch fixes the animated gif corruption people have been seeing. I'll see if I can get some sort of test together for it (this could be quite tricky)

Comment 6

[Joe Drew (not getting mail)]

This is an ultra-safe fix that should have made it into 1.9.2, and we shouldn't accidentally leave a bunch of animated images broken for 3.5.2.

Comment 7

[Joe Drew (not getting mail)]

Here is what happens:

We have a GIF image whose first frame does not cover the full container. Its disposal specifies "Keep." The next frame is smaller still than the first frame, so some of the first frame should show through. But since the GIF is not disposing properly because of the incorrect bracing, it should get a blank background instead.

I think this is the only symptom, other than extra drawing, that should result from this bug. But I've been wrong before: see comment 0.

Comment 9

[Max Stepin]

aFrameToUse doesn't serve any purpose anymore, does it?

Comment 11

[Terry Mester]

This Bug has not been fixed.  I am the author of Bug 546186.

Comment 12

[Joe Drew (not getting mail)]

I can't check it in until I get approval.

Comment 13

[Max Stepin]

Joe, could you please take a look at animation bug 546272?

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

b+a1.9.2=beltzner

Comment 15

[Joe Drew (not getting mail)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/0a4e39d6cb7e

Comment 16

[Terry Mester]

(In reply to comment #15)
> http://hg.mozilla.org/releases/mozilla-1.9.2/rev/0a4e39d6cb7e

Is this a fix to this problem?  If so, will this fix be added to the next update of Firefox?

Comment 17

[Joe Drew (not getting mail)]

Yes.

Comment 21

[Al Billings [:abillings - ex-MoCo]]

I've verified that 546186 is fixed in 3.6.2 (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.2pre) Gecko/20100315 Namoroka/3.6.2pre (.NET CLR 3.5.30729)).

Is that enough to verify this fix or is there another way to verify this?

Comment 22

[Joe Drew (not getting mail)]

That's enough to verify this fix.

Comment 23

[halrod2.a]

The bug still exists for me. I have seen people claiming it was fixed for them viewing the same images as I have, but for some reason there's a difference between us.

I've also tested with this image (taken from a bug which is a duplicate of this one):
http://www.startrekitalia.com/publicnew/avatars/dracon.gif

I see no animation in the animated gif above. Here are the version details that I'm using (taken from Help -> About):
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2

Just in case, I tried the usual stuff: clear cache, restart etc. Any idea why it's still borked for some of us?

Thanks..

Comment 24

[halrod2.a]

Ok, some more info about the problem I've reported earlier, that might help shed some light on the source of the problem:

I have 2 profiles on my Firefox: the default one and and secondary one. I'm using the secondary one for most of my browsing. I have a shortcut I'm using to start FF with the secondary account, using the following command line:

   "C:\Program Files\Mozilla Firefox\firefox.exe" -p other_profile_name

1. When using this secondary profile gifs are *not* being animated correctly!
2. When I use the default profile the same animated gifs are animated correctly.
3. I've started a new (3rd) profile and animated gifs are working correctly there.

I'm not sure why this difference occurs, but it is happening to me consistently. Perhaps the upgrade somehow needed to update the profiles and failed to do so on my secondary profile? If that's the case, is there any way to fix it manually?

Thanks..

Comment 25

[halrod2.a]

Another update:

I found what was causing the error, but I have no idea how that situation occurred. After I realized it was a profile issue (see previous post), I started checking the settings inside my profile. I found the in prefs.js I had the following setting:

   user_pref("image.animation_mode", "none");

That looked suspicious so I removed it and animated gifs started working again!

Now that's the first time I've ever noticed that setting and I've never ever touched it before. Only a speculation here, but is it possible that FF 3.6.0 somehow added this, causing animated gifs to stop working, then during the upgrade to 3.6.2 this setting was supposed to be removed but due to an issue in the upgrade process was only removed in the default profile?

Anyway, that's my resolution of the issue. Hope it helps anyone ;)

Comment 26

[Joe Drew (not getting mail)]

Nope, that's been there forever, but there's lots of reasons why you might've had that set - extensions, experimenting with other settings (and subsequently forgetting about it!), etc.

Comment 27

[halrod2.a]

I haven't experimented with any setting in at least 6 months, probably more, and certainly not with that particular setting.

Anyway, that was just my assessment of the situation. If no one else confirms that this issue was actually reproduced for them then I agree that it's some sort of issue in my environment, although I honestly can't see how it could've happened specifically in my environment.