Closed Bug 513750 Opened 15 years ago Closed 13 years ago

Can we optimize to OPERATOR_SOURCE for animated images with that blend operation?

Categories

(Core :: Graphics: ImageLib, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: joe, Assigned: joe)

References

()

Details

Attachments

(1 file)

See the URL. Right now we do a CLEAR instead of a direct SOURCE when an animated image has selected SOURCE as its blend operator. Is there any reason we shouldn't use SOURCE when drawing? For example, are we drawing directly to the destination? (If we are, I guess we're already wrong?)
Assignee: nobody → joe
Attachment #397724 - Flags: review?(jmuizelaar)
Comment on attachment 397724 [details] [diff] [review]
optimize to SOURCE

The code above is not strictly equivalent. OPERATOR_CLEAR is restricted to the fill().

However OPERATOR_SOURCE is also an unbounded operator but will not be restricted when Paint is called.

Does this code have tests?
Attachment #397724 - Flags: review?(jmuizelaar) → review-
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: