513822 - [mozmill] - Disable Cookies

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Aakash Desai [:aakashd]]

Attachment: patch

The testscript disables cookie saving via the preferences dialog, goes to mozilla.org and then checks that cookies are not saved on the cookies manager.

Litmus Testcases Represented:
 * Testcase ID #8053 - Disabling Cookies 
 * Testcase ID #6011 - Disabling Cookies

Comment 1

[Aakash Desai [:aakashd]]

There's an issue with windows xp.

Comment 2

[Aakash Desai [:aakashd]]

Attachment: patch to review

This patch works on WinXP due to an added sleep(500) and sleep(gDelay) when
accessing the privacyPane HistoryMode and cookies' manager.

Comment 3

[Aakash Desai [:aakashd]]

Attachment: patch with changes made to preference dialog handler

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 398512 [details] [diff] [review]
patch with changes made to preference dialog handler

>+  module.cm = Cc["@mozilla.org/cookiemanager;1"]
>+                         .getService(Ci.nsICookieManager2);

Nit: indentation

>+var teardownModule = function(module)
>+{
>+  PrefsAPI.preferences.branch.clearUserPref("network.cookie.cookieBehavior");
>+  cm.removeAll();	

Please encapsulate it in try/catch. It's easier for me to remove for 1.9.2 as to add each time.

>+  var historyMode = new elementslib.ID(controller.window.document, "historyMode");
>+  controller.waitForElement(historyMode);

click directly

>+  if (PrefsAPI.preferences.getPref("network.cookie.cookieBehavior", "") != 2) 
>+  {
>+    controller.click(new elementslib.ID(controller.window.document, "acceptCookies"));
>+  }

Check the boxes via getNode.check.

>+  // Fails due to bug 513820 

Just write it like: "// XXX: Bug 513820 + short description

>+  // Close the cookies manager and the preferences dialog
>+  cmController.keypress(null, "w", {accelKey: true});	

Please add a short timeout.

Otherwise it looks good too. r=me with this changes.

Comment 5

[Aakash Desai [:aakashd]]

Attachment: patch_disableCookies

This patch contains fixes for the comments made in the previous review.

Comment 6

[Aakash Desai [:aakashd]]

Comment on attachment 399763 [details] [diff] [review]
patch_disableCookies

Disregard the patch comment #5, this is a WIP.

Comment 7

[Aakash Desai [:aakashd]]

Attachment: patch_disableCookies

Ok, so changes were made form the previous review and I had to add the waitForElement back to historyMode as the testscript failed when it was removed on OSX for Fx3.5.3.

Comment 8

[Aakash Desai [:aakashd]]

Attachment: patch_disableCookies

Sorry, for the extra patch...I forgot the summary in bug 513820's comment.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 399865 [details] [diff] [review]
patch_disableCookies

>+  module.cm = Cc["@mozilla.org/cookiemanager;1"]
>+                     .getService(Ci.nsICookieManager2);

The indentation is still wrong. I assume that you are using tabs in your editor? Please make sure to switch to 2 blanks.

>+  PrefsAPI.preferences.branch.clearUserPref("network.cookie.cookieBehavior");

Please always wrap it into try/catch. I will remove it later before checking into trunk. Adding them for myself is more work for me.

>+ * prefDisableCookieDialogCallback - Goes to the privacy pane disables cookie saving

You don't have to call the function name. The description is enough.

>+  // Go to custom history settings and click on the show cookies button
>+  var historyMode = new elementslib.ID(controller.window.document, "historyMode");
>+  controller.waitForElement(historyMode);

Mmh. I don't understand why we have to wait here. It should not be necessary. But ok, lets use waitForElement. Please make sure to always pass gTimeout to the function call in the future.

>+  if (acceptCookiesPref.getNode().checked==true) 

'==true' is not necessary.

I'll make those changes and check it in. Thanks.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: For checkin

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/8e65134caa10
http://hg.mozilla.org/qa/mozmill-tests/rev/84f204a5159a

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.