CodeAlloc is missing cache-flush code for Android

VERIFIED FIXED

Status

Tamarin
Baseline JIT (CodegenLIR)
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Steven Johnson, Assigned: Steven Johnson)

Tracking

Details

Attachments

(2 obsolete attachments)

(Assignee)

Description

9 years ago
Created attachment 397767 [details] [diff] [review]
Add missing stub for android

What it says.
Attachment #397767 - Flags: review?(edwsmith)

Comment 1

9 years ago
Comment on attachment 397767 [details] [diff] [review]
Add missing stub for android

__clear_cache is usually a glibc or gcc provided symbol, i dont think we should be defining it -- instead we just need a separate case for android that calls cacheflush() directly instead of __clear_cache.

(Rick or I can pick this up if you want to transfer responsibility).
Attachment #397767 - Flags: review?(edwsmith) → review-
(Assignee)

Comment 2

9 years ago
(In reply to comment #1)
> (From update of attachment 397767 [details] [diff] [review])
> (Rick or I can pick this up if you want to transfer responsibility).

Fine with me -- exact fix should be pretty trivial either way. This was the short-term fix shown to me, but it probably makes more sense to do it the way you suggest.

Updated

9 years ago
Assignee: nobody → rreitmai
(Assignee)

Comment 3

9 years ago
Created attachment 399318 [details] [diff] [review]
revised patch

revised patch per Edwin's comment. Also removed defunct bit in NativeARM.cpp -- note that AVMPLUS_LINUX is never defined!
Assignee: rreitmai → stejohns
Attachment #397767 - Attachment is obsolete: true
Attachment #399318 - Flags: superreview?(edwsmith)
Attachment #399318 - Flags: review?(rreitmai)

Updated

9 years ago
Attachment #399318 - Flags: review?(rreitmai) → review+

Updated

9 years ago
Attachment #399318 - Flags: superreview?(edwsmith) → superreview+
(Assignee)

Comment 4

9 years ago
Comment on attachment 399318 [details] [diff] [review]
revised patch

pushed as changeset:   2467:4fb2e5253577
Attachment #399318 - Attachment is obsolete: true

Updated

9 years ago
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.