nanojit: some regalloc comments, etc

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 397768 [details] [diff] [review]
patch

This patch adds some helpful comments, and make some tweaks:

- Avoids passing an argument to findVictim() that it can access instead via an
  object field.

- Documents findRegFor(), evictIfActive(), evict().

- Makes the comment about dead code elimination more concise, and adds some
  details about register allocation.

- Makes evictRegs() more concise.
Attachment #397768 - Flags: review?(edwsmith)
(Assignee)

Comment 1

8 years ago
Created attachment 397769 [details] [diff] [review]
revised patch
Attachment #397768 - Attachment is obsolete: true
Attachment #397769 - Flags: review?(edwsmith)
Attachment #397768 - Flags: review?(edwsmith)

Comment 2

8 years ago
Comment on attachment 397769 [details] [diff] [review]
revised patch

+1 on the comment wording.  fwiw, i think of the current RegAlloc and AR state as a contract that we must meet to satisfy code we have already emitted.

in findVictim, it might help a tiny bit for _allocator to be in a local variable instead of accessing [this.]_allocator inside the loop.  (C++ compiler might not eliminate the load).

or, maybe it won't matter at all.
Attachment #397769 - Flags: review?(edwsmith) → review+
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/tracemonkey/rev/c5adc7d02a84
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/c5adc7d02a84
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
status1.9.2: --- → beta1-fixed

Comment 5

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a877dc3e9402
You need to log in before you can comment on or make changes to this bug.