Closed Bug 513895 Opened 11 years ago Closed 9 years ago

Audit preference panes for duplicate stylesheets

Categories

(SeaMonkey :: Preferences, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.5

People

(Reporter: neil, Assigned: ewong)

References

Details

Attachments

(1 file, 2 obsolete files)

The old XPFE widget state manager loaded each preference pane into a separate iframe thus requiring it to have its own stylesheet reference. However the toolkit prefwindow overlays each page into the same window so that none of the panes need to overlay any of the default stylesheets that the prefwindow loads.
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #542805 - Flags: review?(neil)
Attachment #542805 - Flags: review?(neil) → review?(iann_bugzilla)
> +++ b/suite/common/pref/pref-policies.xul
pref-policies is an old style prefpanel not used any more I don't think.
commented out in 2000AD via  bug 44121.

> +++ b/suite/common/pref/pref-proxies-advanced.xul
Eeek. This is not an overlay but a standalone window. Don't remove the stylesheet here.

> +++ b/suite/common/pref/pref-smartupdate.xul
> -<?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?>
> -
>  <!DOCTYPE page [
While you are at it change the DOCTYPE page to DOCTYPE overlay.
Comment on attachment 542805 [details] [diff] [review]
Removed duplicate stylesheets from pref-*.xul

>+++ b/suite/common/pref/pref-applicationManager.xul
>-<?xml-stylesheet href="chrome://communicator/skin/"?>
>-
> <!DOCTYPE dialog SYSTEM "chrome://communicator/locale/pref/pref-applicationManager.dtd">
This is a dialog, so don't remove from this one either.

Rest as per Ratty's drive-by.

Did you check the files in suite/mailnews/prefs ?
Attachment #542805 - Flags: review?(iann_bugzilla) → review-
Keywords: helpwanted
> Did you check the files in suite/mailnews/prefs ?
and editor/ui/composer/content/pref-*.xul
Attachment #542805 - Attachment is obsolete: true
Attachment #543126 - Flags: review?(iann_bugzilla)
Comment on attachment 543126 [details] [diff] [review]
Removed duplicate stylesheets from pref-*.xul (v2)

>+++ b/suite/common/pref/pref-policies.xul
As Ratty said, not in use, so don't change.

>+++ b/suite/mailnews/prefs/pref-notifications.xul

> <?xml-stylesheet href="chrome://messenger/skin/prefPanels.css" type="text/css"?>
>-<?xml-stylesheet href="chrome://communicator/skin/" type="text/css"?>

>+++ b/suite/mailnews/prefs/pref-offline.xul

>-<?xml-stylesheet href="chrome://messenger/skin/prefPanels.css" type="text/css"?>
>-
Why delete this entry?

>+++ b/suite/mailnews/prefs/pref-receipts.xul

>-<?xml-stylesheet href="chrome://messenger/skin/prefPanels.css" type="text/css"?>
>-
And again?

>+++ b/suite/mailnews/prefs/pref-tags.xul

>-<?xml-stylesheet href="chrome://messenger/skin/prefPanels.css" type="text/css"?>
>-
And again?

prefPanels.css in messenger is different to the one in communicator and contains css for pref-tags.xul

r- for the moment
Attachment #543126 - Flags: review?(iann_bugzilla) → review-
(In reply to comment #6)
> prefPanels.css in messenger is different to the one in communicator and
> contains css for pref-tags.xul
Now that you mention it, messenger's prefPanels.css contains a presumably unnecessary reference to communicator's prefpanels.css! (The other stylesheet reference might also be unnecessary, but less obviously.)
Attachment #543126 - Attachment is obsolete: true
Attachment #545041 - Flags: review?(iann_bugzilla)
Comment on attachment 545041 [details] [diff] [review]
Removed duplicate stylesheets from pref-*.xul (v3) [Checked in: Comment 11]

r=me. did you want to deal with Neil's comment in this bug or a separate one?
Attachment #545041 - Flags: review?(iann_bugzilla) → review+
(In reply to comment #9)
> Comment on attachment 545041 [details] [diff] [review] [review]
> Removed duplicate stylesheets from pref-*.xul (v3)
> 
> r=me. did you want to deal with Neil's comment in this bug or a separate one?

I think it's appropriate to deal with it in a separate bug.
Blocks: 670652
Keywords: checkin-needed
Comment on attachment 545041 [details] [diff] [review]
Removed duplicate stylesheets from pref-*.xul (v3) [Checked in: Comment 11]

http://hg.mozilla.org/comm-central/rev/ec2edbeb7888
Attachment #545041 - Attachment description: Removed duplicate stylesheets from pref-*.xul (v3) → Removed duplicate stylesheets from pref-*.xul (v3) [Checked in: Comment 11]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.5
You need to log in before you can comment on or make changes to this bug.