Move devhub pages to a new controller so they're not login-protected

VERIFIED FIXED in 5.1

Status

addons.mozilla.org Graveyard
Developer Pages
P1
normal
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: jbalogh, Assigned: jbalogh)

Tracking

unspecified

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

9 years ago
Priority: -- → P1
(Assignee)

Comment 1

9 years ago
Created attachment 398788 [details] [diff] [review]
moving devhub static pages to a new controller

--comment=Ideally, this would go in when there are no incoming patches for these pages because the renames are going to throw off svn.  If only there was a vcs that could handle renames...
Attachment #398788 - Flags: review?(clouserw)
Hm? SVN does handle renames.
Comment on attachment 398788 [details] [diff] [review]
moving devhub static pages to a new controller

The concept is fine, so I'm r+ing, but use `svn mv` to move the files. (or I can if you don't have an svn checkout handy).
Attachment #398788 - Flags: review?(clouserw) → review+
(Assignee)

Comment 4

9 years ago
(In reply to comment #3)
> (From update of attachment 398788 [details] [diff] [review])
> The concept is fine, so I'm r+ing, but use `svn mv` to move the files. (or I
> can if you don't have an svn checkout handy).

I don't have anything with svn, can you apply this patch and move the files the right way?  Thanks.
r51361.  Somewhat untested but I figured it will get lots of testing elsewhere.  QA: We just want to make sure the /developers/ URLs still work, and double check the search too.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
I moved the hub index to the new controller in r51370.
Verified FIXED; I tested as requested in comment 5.  (https://preview.addons.mozilla.org/en-US/developers/addon/validate intentionally requires login, as expected.)
Status: RESOLVED → VERIFIED
Actually, that's not expected. Validator is open to everyone. You have to be logged in to actually upload an add-on or select one of your existing add-ons, but you should be able to load the page and read what it is, as described in bug 513135. But please file a new bug for it.
(In reply to comment #8)
> Actually, that's not expected. Validator is open to everyone. You have to be
> logged in to actually upload an add-on or select one of your existing add-ons,
> but you should be able to load the page and read what it is, as described in
> bug 513135. But please file a new bug for it.

Filed bug 516904, thanks!
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.