514029 - renderCanvas JS error: cr is null

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Benjamin Stover (:stechz)]

Steps to repro:
1. Go to https://developer.mozilla.org/En/Error_Console
2. Click Firebug (basically anything that opens a new tab).
3. JS console error: cr is null

Comment 1

[Benjamin Stover (:stechz)]

http://mxr.mozilla.org/mobile-browser/source/chrome/content/BrowserView.js#534

If the intersection of two rectangles is the null set, then intersect (and thus visibleRectToCriticalRect) return null.  This can happen if a tab's browser view state has been initialized for a tab but the viewport has not been set (for example, a fit to page call hasn't been made).

I think it is counterintuitive that any rectangle operation could return null.  Maybe intersect should return a rect(0,0,0,0) and rect should have an isEmpty method.  Thoughts?

Comment 2

[Benjamin Stover (:stechz)]

Attachment: Use defaults of 0 instead of 1

If document has not finished loading, default to a browser width and height of (1,1) so viewport isn't empty and intersection is null.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/da4912e8a244