514058 - ThunderbirdTry: pass mozconfigs to dos2unix before processing

Status: RESOLVED INVALID

(Mozilla Messaging Graveyard :: Try Server, defect)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1251842625.1251843419.5367.gz&fulltext=1
Try server comm-central linux hg builder on 2009/09/01 15:03:45
{
Adding configure options from /mnt/buildbot/sendchange-linux-hg/mozilla/.mozconfig:
  --enable-application=mail
  --disable-shared
  --enable-static
  --disable-debug
  --disable-tests
  --enable-optimize
  --enable-tree-freetype

configure: error: tree-freetype
: invalid feature name
*** Fix above errors and then restart with               "make -f client.mk build"
make[1]: *** [configure] Error 1
make[1]: Leaving directory `/mnt/buildbot/sendchange-linux-hg/mozilla'
}

I used 'ac_add_options --enable-tree-freetype'.
What wrong with that?

Comment 1

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTry/1251842628.1251847008.12946.gz&fulltext=1
Try server comm-central mac hg builder on 2009/09/01 15:03:48

Comment 2

[Philippe M. Chiasson (:gozer)]

There is a ^M at the end of the submitted mozconfig. That's what is causing configure to fail.

Comment 3

[Serge Gautherie (:sgautherie)]

Ah, this explains why the error seemed split on 2 lines :->

Yet, couldn't this case be supported?
Or at least a reminder added to the submit form?

This file is not tracked in hg (...) so this could happen again.

Comment 4

[Mark Banner (:standard8)]

Thunderbird's try server is based on the same code as mozilla-central. So I presume the same issue is in their code unless they've done something to fix it already (which I doubt).

Comment 5

[Serge Gautherie (:sgautherie)]

I have no idea:
I do "hg push ... -f try" only on m-c,
afaik I don't have a LDAP account to access the submit form there :-|

Shall I just morph this bug accordingly anyway?

Comment 6

[Philippe M. Chiasson (:gozer)]

Guess I could feed the mozconfigs to 'dos2unix' before sending out for trying

Comment 7

[Philippe M. Chiasson (:gozer)]

Not a problem anymore with push-to-try.