Closed Bug 514072 Opened 10 years ago Closed 10 years ago

upgrade windows xp/vista to tango border quote colors

Categories

(Thunderbird :: Message Reader UI, defect)

All
Windows Vista
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b4

People

(Reporter: clarkbw, Assigned: clarkbw)

References

Details

Attachments

(1 file, 1 obsolete file)

we missed this from the theme updates.  I basically copied what we did in the gnomestripe theme.  The colors are a lot softer and nicer than the blue, green, maroon combo currently used.
Attachment #398018 - Flags: review?(philringnalda)
Comment on attachment 398018 [details] [diff] [review]
tango message quote border colors

>+  color: rgb(114,159,207) /* Sky Blue 1 */

Missing a semicolon

>+  border-width: 0px 2px 0px 2px;

0 doesn't need/shouldn't have a unit, and there's no need for four values there, where two will do.
Attachment #398018 - Flags: review?(philringnalda) → review+
here's a new version with the comments addressed
Attachment #398018 - Attachment is obsolete: true
Attachment #399156 - Flags: review+
Comment on attachment 399156 [details] [diff] [review]
updated patch with comments addressed

carrying forward the r+
Assignee: nobody → clarkbw
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/eaed6a7430a2
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b4
Comment on attachment 399156 [details] [diff] [review]
updated patch with comments addressed

Oh and a=me for checkin during the freeze.
Attachment #399156 - Flags: approval-thunderbird3+
You need to log in before you can comment on or make changes to this bug.