514076 - Fennec produces a error report with enable-faststart and Screen rotation

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[kantha kanchiraju]

User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; GTB6; .NET CLR 1.1.4322; InfoPath.2; .NET CLR 2.0.50727; .NET CLR 3.0.04506.648; .NET CLR 3.5.21022)
Build Identifier: Fennec 1.0a3 Xulrunner 1.9.3a1pre

Built Fennec with --enable-faststart and installed it on a Samsung Omnia Device and as well as a Windows Mobile Professional 6 Emulator.
Reboot the device or Emulator and rotate the screen, either manually or through Auto Motion Sensor. Access_Violation occurs and a error report is generated. Fennec continues to run.

Reproducible: Always

Steps to Reproduce:
1.Install Fennec with Browserd
2.Reboot the device
3.rotate the screen by changing the screen orientation setting or by rotating the device
4.Error report is generated for Fennec.exe

Comment 1

[kantha kanchiraju]

Attachment: Patch for screen rotation crash

Browser Deamon is crashing when the screen is rotated before starting fennec. 

Looks like OnSettingsChangeGfx is getting called on the hidden window when the screen is rotated, where the glpDD->RestoreAllSurfaces is getting invoked and glpDD is NULL. thsi patch makes sure glpDD is not NULL beofer invoking RestoreAllSurfaces.

OnSettingChangeGfx is getting called once for each and every window in the Fennec App. This patch as per Doug Turner's suggestion checks if the window is  a TopLevel or a Dialog before calling OnSettingChangeGfx.

Comment 2

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/0787e89e3e0d

thanks kantha!

Comment 3

[Doug Turner (:dougt)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/aecf09956fc5