514117 - Bogus code in nsDocAccessible::GetBoundsRect

Status: NEW

(Core :: Disability Access APIs, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsDocAccessible.cpp#756

This code is quite wrong. viewBounds is always relative to the the view's parent view, but this code is assuming that all viewBounds are in the same coordinate system, which is totally not true.

Comment 1

[Marco Zehe (:MarcoZ)]

Thanks Roc!

Comment 2

[alexander :surkov (:asurkov)]

Roc, how to fix this one?

Comment 3

[alexander :surkov (:asurkov)]

(In reply to alexander :surkov from comment #2)
> Roc, how to fix this one?

intersecting screen rects?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Record which frame the rectangle is relative to, and each time you want to do an intersection call nsLayoutUtils::TransformFrameRectToAncestor to transform the previous rectangle to the coordinate system of the next rectangle.

Comment 5

[alexander :surkov (:asurkov)]

Robert, can you think of example to reproduce a bug?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

An outer document in a 100x100 container containing an IFRAME at offset 50,50 which is also 100x100. Everything overflow:hidden. This code will return a rectangle (0,0,100,100) when it should return a rectangle that's 50x50 (I'm not sure what the offset should be though).

Comment 7

[alexander :surkov (:asurkov)]

Jamie, do you know why document accessible is special, i.e. it's rectangle is restricted by visible area but Theany other accessible don't have this? I checked IE, it seems they do the same.

Comment 8

[Morgan Reschenberg [:morgan]]

• deleted - gonna post this to a new bug because not entirely convinced this is the same problem!