Kill xpcom/obsolete

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Core
XPCOM
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: Mitch, Assigned: Mitch)

Tracking

Trunk
mozilla1.9.3a1
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 398088 [details] [diff] [review]
Patch v1.0

It's obsolete and should go away.
This patch is an attempt to make it go away.
Attachment #398088 - Flags: review?(benjamin)
(Assignee)

Comment 1

8 years ago
Created attachment 398089 [details] [diff] [review]
Patch v1.1

This actually builds.
Attachment #398088 - Attachment is obsolete: true
Attachment #398089 - Flags: review?(benjamin)
Attachment #398088 - Flags: review?(benjamin)
(Assignee)

Comment 2

8 years ago
Created attachment 398122 [details]
Bundle v1.1

This is a bundle of the previous changes.
(Assignee)

Updated

8 years ago
Attachment #398122 - Attachment is patch: false
Attachment #398122 - Attachment mime type: text/plain → application/octet-stream
Attachment #398089 - Flags: review?(benjamin) → review+
Comment on attachment 398089 [details] [diff] [review]
Patch v1.1

Awesome.

Please file a followup bug about removing the nsIPref API which is no longer supported (Get/SetFilePref)
Blocks: 513924
http://hg.mozilla.org/mozilla-central/rev/d578481cbc37
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Version: unspecified → Trunk
Duplicate of this bug: 282808
(In reply to comment #3)
> (From update of attachment 398089 [details] [diff] [review])
> Awesome.
> 
> Please file a followup bug about removing the nsIPref API which is no longer
> supported (Get/SetFilePref)

It is filed as bug 214796.

Updated

8 years ago
Depends on: 38122
Blocks: 540470
Flags: in-testsuite-
Comment on attachment 398089 [details] [diff] [review]
Patch v1.1

>diff --git a/configure.in b/configure.in
>-if test -n "$MOZ_NO_XPCOM_OBSOLETE" && test `echo "$MOZ_EXTENSIONS" | grep -c sroaming` -ne 0; then
>-    AC_MSG_WARN([Cannot currently build sroaming without xpcom obsolete -- bug 249343. Removing sroaming from MOZ_EXTENSIONS.])
>-    MOZ_EXTENSIONS=`echo $MOZ_EXTENSIONS | sed -e 's|sroaming||'`
>-fi

Bug 249343 is not fixed. Why remove this code?
You need to log in before you can comment on or make changes to this bug.