Closed Bug 514131 Opened 14 years ago Closed 14 years ago

Kill xpcom/obsolete

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a1

People

(Reporter: Mitch, Assigned: Mitch)

References

Details

Attachments

(2 files, 1 obsolete file)

Patch v1.1
430.49 KB, patch
benjamin
: review+
Details | Diff | Splinter Review
Bundle v1.1
2.94 KB, application/octet-stream
Details
Attached patch Patch v1.0 (obsolete) — — Splinter Review 
It's obsolete and should go away.
This patch is an attempt to make it go away.
Attachment #398088 - Flags: review?(benjamin)
Attached patch Patch v1.1 — — Splinter Review 
This actually builds.
Attachment #398088 - Attachment is obsolete: true
Attachment #398089 - Flags: review?(benjamin)
Attachment #398088 - Flags: review?(benjamin)
Attached file Bundle v1.1 — 
This is a bundle of the previous changes.
Attachment #398122 - Attachment is patch: false
Attachment #398122 - Attachment mime type: text/plain → application/octet-stream
Attachment #398089 - Flags: review?(benjamin) → review+
Comment on attachment 398089 [details] [diff] [review]
Patch v1.1

Awesome.

Please file a followup bug about removing the nsIPref API which is no longer supported (Get/SetFilePref)
http://hg.mozilla.org/mozilla-central/rev/d578481cbc37
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Version: unspecified → Trunk
(In reply to comment #3)
> (From update of attachment 398089 [details] [diff] [review])
> Awesome.
> 
> Please file a followup bug about removing the nsIPref API which is no longer
> supported (Get/SetFilePref)

It is filed as bug 214796.
Depends on: 38122
Flags: in-testsuite-
Comment on attachment 398089 [details] [diff] [review]
Patch v1.1

>diff --git a/configure.in b/configure.in
>-if test -n "$MOZ_NO_XPCOM_OBSOLETE" && test `echo "$MOZ_EXTENSIONS" | grep -c sroaming` -ne 0; then
>-    AC_MSG_WARN([Cannot currently build sroaming without xpcom obsolete -- bug 249343. Removing sroaming from MOZ_EXTENSIONS.])
>-    MOZ_EXTENSIONS=`echo $MOZ_EXTENSIONS | sed -e 's|sroaming||'`
>-fi

Bug 249343 is not fixed. Why remove this code?
You need to log in before you can comment on or make changes to this bug.