514235 - Add GC instance count to memory info dump

Status: VERIFIED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), enhancement, P5)

Description

[Rishit Shah]

Sometimes, while debugging memory usage issues on websites it is useful to know the number of active GC instances.

Adding this instance count info to DumpMemoryInfo would help the developer.

Comment 1

[Lars T Hansen]

Attachment: Patch - count the GCs, dump with gross stats

Comment 2

[Lars T Hansen]

pushed pending review: redux changeset:   2609:31e7c1c504b4

Comment 3

[Steven Johnson]

Comment on attachment 402826 [details] [diff] [review]
Patch - count the GCs, dump with gross stats

Don't we need a "gc_count -= 1" somewhere?

Comment 4

[Lars T Hansen]

(In reply to comment #3)
> (From update of attachment 402826 [details] [diff] [review])
> Don't we need a "gc_count -= 1" somewhere?

Shouldn't be necessary, because the code computes gc_count every time it needs it (once every GC) by walking the list of garbage collectors.  When a collector is destroyed it is removed from that list, and the next time the count is printed it will be recomputed correctly.

Comment 5

[Chris Peyer]

Resolved fixed engineering / work item that has been pushed.  Setting status to verified.