runtest.py output updates

VERIFIED FIXED

Status

Tamarin
Tools
--
enhancement
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: Brent Baker, Assigned: Chris Peyer)

Tracking

unspecified
Bug Flags:
flashplayer-triage +

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

9 years ago
1) Remove the outputting of html data. This is no longer used and is just dead code. Also remove the --nohtml switch

2) Add the ability to output the summary data as csv via --csvoutput switch
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
(Assignee)

Updated

9 years ago
Assignee: nobody → cpeyer
Status: NEW → ASSIGNED
(Assignee)

Comment 1

9 years ago
Created attachment 398505 [details] [diff] [review]
add csv output ability

This patch adds:
- csv output to stdout using the --csv flag
- replaces --nohtml with --html and turn html output off by default
- fix variance calculation
- fix output of memory results when comparing 2 vms with multiple iterations
- add info message describing how %diff is calculated
Attachment #398505 - Flags: review?(brbaker)
(Reporter)

Comment 2

9 years ago
Created attachment 400076 [details] [diff] [review]
fix spdup when larger is faster

This is a patch that Edwin has provided and rebased to the first patch in this bug
Attachment #400076 - Flags: review?(cpeyer)
(Reporter)

Comment 3

9 years ago
Comment on attachment 398505 [details] [diff] [review]
add csv output ability

- should be able to drop the 'nohtml' from util/runtestBase.py:255
- I sort of liked the older style of output when running a single VM with -i #, was a little more compact than the new style
Attachment #398505 - Flags: review?(brbaker) → review+
(Assignee)

Comment 4

9 years ago
Created attachment 400147 [details] [diff] [review]
Updated patch that incorporates Brents feedback.

This patch incorporates both previous patches.

I changed the display format with multiple iterations back to its more compact format when displaying to screen, but when outputting to csv, individual column headers will be outputted.  'nohtml' command line option also removed from runtestBase.py
Attachment #398505 - Attachment is obsolete: true
Attachment #400076 - Attachment is obsolete: true
Attachment #400147 - Flags: review?(brbaker)
Attachment #400076 - Flags: review?(cpeyer)
(Assignee)

Comment 5

8 years ago
Pushed to TR with  2490:3234a1ebaee0 and 2493:54bb214e3883
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Status: RESOLVED → VERIFIED
(Reporter)

Updated

8 years ago
Attachment #400147 - Flags: review?(brbaker)
(Reporter)

Comment 6

8 years ago
removing QRB request, bug resolved/verified
Flags: flashplayer-qrb?
You need to log in before you can comment on or make changes to this bug.