514315 - undeclared variables on stats tab

Status: RESOLVED FIXED

(Other Applications Graveyard :: QA Companion, defect)

Description

[Heather Arthur [:harth]]

getting these in the error console:

Warning: assignment to undeclared variable weekly
Source File: chrome://qa/content/tabs/stats.js
Line: 78

for a bunch of variables.

Comment 1

[Aaron Train [:aaronmt]]

Forgive my js scoping knowledge but by declaring these variables global are they not defined before the call to them?

See line 39 in stats.js

Comment 2

[Heather Arthur [:harth]]

ahh, I see what you're trying to do. Just say 'qaStats.monthly' instead of 'monthly' ('this.monthly' also works, but in the QAC code we never use 'this' because of all of our callbacks, so we should stay consistent) and put var's before all i's in the for loop declarations.

Comment 3

[Aaron Train [:aaronmt]]

Attachment: Warning fixes for variables in stats

This patch addresses those warning as well as introduces local variable declaration within the loops in setStars()

Comment 4

[Heather Arthur [:harth]]

Comment on attachment 398316 [details] [diff] [review]
Warning fixes for variables in stats

yay!

Comment 5

[Heather Arthur [:harth]]

Sending        chrome/content/tabs/stats.js
Transmitting file data .
Committed revision 50791.