514331 - CodegenLIR should use precomputed multinames instead of LIR_alloc and stores

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Edwin Smith]

Wordcode interpreter has an optimization to add a table of multinames to PoolObject, and use them directly.  The JIT would benefit from this because the code to explicitly stack-allocate and initialize a fully constant multiname, is just bloat.  and, it adds to jit compile time.

we should generalize the precomputed name table and enable it with both the wordcode and jit features.

Comment 1

[Edwin Smith]

Attachment: Refactor precomputed multiname feature so its enabled by wordcode and jit feature

also removed dead macro GET_MULTINAME in interpreter.  only GET_MULTINAME_PTR is used.

Comment 2

[Edwin Smith]

Attachment: use precomputedMultiname instead of parseMultiname

the crutial change is to actually inline a pointer to the precomputed multiname in jit'd code, if the multiname has no runtime parts (fixed name, fixed namespace).  see CodegenLIR::initMultiname().

Comment 3

[Edwin Smith]

static IR stats for:

avmshell -Ojit -Dnodebugger -Dverifyall esc/main.swf -- hello.as

instr count  before       precomputed    change
-----------  ------       -----------    ------
total LIR    318470       293572         -7.8%
lir-alloc    17372        11677          -33%
lir-st       46949        29864          -36%

Comment 4

[Rick Reitmaier]

Comment on attachment 398304 [details] [diff] [review]
use precomputedMultiname instead of parseMultiname

(1) Does pool->precomputedMultiname() exist in another patch?

(2) Too bad we can't assert ( pool->precomputedMultiname(opd1)) in initMultiname() or somesuch.

Comment 5

[Edwin Smith]

(1) yes, its in the previous patch on this bug
(2) I'll look into it and add if feasible

Comment 6

[Edwin Smith]

Comment on attachment 398303 [details] [diff] [review]
Refactor precomputed multiname feature so its enabled by wordcode and jit feature

pushed 
http://hg.mozilla.org/tamarin-redux/rev/676c9d277388

Comment 7

[Edwin Smith]

http://hg.mozilla.org/tamarin-redux/rev/2436fdccc65d

Comment 8

[Chris Peyer]

Resolved fixed engineering / work item that has been pushed.  Setting status to verified.