514401 - [shared module] Need helper functions for preferences dialog (open/close dialog, get/set a pane)

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

For handling the preferences dialog we have to c&p a lot of code which should not be necessary. We should add two new functions for selecting the specified pane and for closing the dialog. It can replace all the currently used instances and will make its handling much easier.

I will take care of it.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Simplify handling of preferences dialog

This is an API change. I have updated all tests which uses the preferences dialog. Now we have functions to handle the following actions:

* open/close the dialog
* get and set the active pane

This patch applies to the mozilla1.9.1 branch. For trunk I have to update the patch probably.

Comment 2

[cmtalbert]

Comment on attachment 398414 [details] [diff] [review]
Simplify handling of preferences dialog

Discussed on IRC:
So, the only nit I have is that the functions in the preference module are all anonymous.  Can we give them small names so that they show up in the debugger later.
[3:14pm] ctalbert: Something like open : function pmo(blah blah) {  ...
[3:14pm] ctalbert: where pmo stands for PrefModuleOpen
[3:14pm] whimboo: oooh for sure
[3:15pm] ctalbert: otherwise, looks great.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/2b3c05d586b0
http://hg.mozilla.org/qa/mozmill-tests/rev/58cdacc009c3

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Tested again on OS X and Windows with Shiretoko and Namoroka. Everything is working fine.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.