We should avoid recording allocations that fail

VERIFIED INVALID

Status

Tamarin
Garbage Collection (mmGC)
P2
normal
VERIFIED INVALID
8 years ago
8 years ago

People

(Reporter: Jason Williams, Assigned: Tommy Reilly)

Tracking

unspecified
flash10.1
x86
Mac OS X

Details

(Reporter)

Description

8 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Build Identifier: latest

When the GC allocates/deallocates memory it will attempt to record these actions, but, when an allocation fails this step should be skipped.

Reproducible: Always

Steps to Reproduce:
1. Run the heap out of memory
2. Try to allocate something from the heap
Actual Results:  
We still attempt to record the failed allocation resulting in asserts.

Expected Results:  
No allocation should be performed.
(Assignee)

Updated

8 years ago
Status: UNCONFIRMED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 1

8 years ago
Tom - Is this fixed?
(Assignee)

Comment 2

8 years ago
TrackSystemAlloc doesn't check for NULL
Status: RESOLVED → UNCONFIRMED
Resolution: FIXED → ---
(Assignee)

Updated

8 years ago
Assignee: nobody → treilly
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Updated

8 years ago
Priority: -- → P2
Target Milestone: --- → flash10.1
(Assignee)

Comment 3

8 years ago
It doesn't need to its never called with NULL SystemNew will Abort if the system allocator fails.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → INVALID

Updated

8 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.