Closed Bug 514486 Opened 15 years ago Closed 15 years ago

We should avoid recording allocations that fail

Categories

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P2)

Product:
Tamarin Graveyard
Component:
Garbage Collection (mmGC)
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED INVALID
Milestone:
flash10.1

People

(Reporter: jasowill, Assigned: treilly)

Details

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Build Identifier: latest

When the GC allocates/deallocates memory it will attempt to record these actions, but, when an allocation fails this step should be skipped.

Reproducible: Always

Steps to Reproduce:
1. Run the heap out of memory
2. Try to allocate something from the heap
Actual Results:  
We still attempt to record the failed allocation resulting in asserts.

Expected Results:  
No allocation should be performed.
Status: UNCONFIRMED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Tom - Is this fixed?
TrackSystemAlloc doesn't check for NULL
Status: RESOLVED → UNCONFIRMED
Resolution: FIXED → ---
Assignee: nobody → treilly
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P2
Target Milestone: --- → flash10.1
It doesn't need to its never called with NULL SystemNew will Abort if the system allocator fails.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → INVALID
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.