514539 - Align Thunderbird's neterror.dtd file with the Firefox neterror.dtd file

Status: RESOLVED WONTFIX

(Thunderbird :: General, defect)

Description

[Simon Paquet [:sipaq]]

The current Thunderbird neterror.dtd file in mail/locales/en-US/chrome/overrides/ has six minor differences with its Firefox equivalent:

1) one missing empty line between lines 34-36
2) Different text in the netOffline.longDesc entity in line 57
3) "Website" instead of "Web site" in the nssFailure2.longDesc entity in 
   line 128
4) One missing sentence "Alternatively, use the command found in the help 
   menu to report this broken site." in the nssFailure2.longDesc entity in 
   line 128
5) "Website" instead of "Web site" in the malwareBlocked.longDesc entity in 
   line 156
6) Mention of "thunderbird" instead of "firefox" in the comment in line 172 


I propose two things:

1. Align the Thunderbird instance with the Firefox equivalent in every aspect 
   except item 6 from above
2. Add a comment at the top for localizers and explain that this file is 
   completely identical with its Firefox equivalent and that they can 
   therefore re-use their existing Firefox localization here.

Comments welcome!

Comment 1

[Phil Ringnalda (:philor)]

Surely we don't want to add in the sentence about the Reporter item in the Help menu, since we don't build Reporter.

Comment 2

[Mark Banner (:standard8)]

Well doing item 2 would actually make the instruction worse seeing as work
offline isn't in the file menu directly.

For item 4 we'd need to bump the number of the string which we're not going to
be allowed to do.

Comment 3

[Phil Ringnalda (:philor)]

Fixing 3 and 5 would be a regression, since we have four instances of "website" while browser/ and dom/ have two of "website" and two of "web site" - the right way to fix those two is to fix them, not us.

Comment 4

[Phil Ringnalda (:philor)]

And then while you are fixing that bug in the mozilla-central files, you could take care of the "missing" empty line, since they pointlessly have two blank lines there instead of one, and then you'd be all set, except for the fact that we don't build Reporter and don't promise to have items in the same menus, and menuitems may or may not have the same labels in an Fx localization and a Tb localization, so the basic idea of "just copy-paste your Firefox file without looking" is impossible to execute.

Comment 5

[Stefan Plewako [:stef]]

> 2) Different text in the netOffline.longDesc entity in line 57

Right, it's intended difference, please check file menu.

> 6) Mention of "thunderbird" instead of "firefox" in the comment in line 172 

So, they are not equal?

> 4) One missing sentence "Alternatively, use the command found in the help 
>    menu to report this broken site." in the nssFailure2.longDesc entity in 
>    line 128

The sentence is not missing, it's the menu entry missing...

> 3) "Website" instead of "Web site" in the nssFailure2.longDesc entity in 
>    line 128
> 5) "Website" instead of "Web site" in the malwareBlocked.longDesc entity in 
>    line 156

and also capitalization in lines: 61(62), 68(69), 124(125), 132(133),  153(154), 159(160).

> 1. Align the Thunderbird instance with the Firefox equivalent in every aspect 
>    except item 6 from above

What for?

> 2. Add a comment at the top for localizers and explain that this file is 
>    completely identical with its Firefox equivalent and that they can 
>    therefore re-use their existing Firefox localization here.

Nice idea but "based on" would be much better than "identical".

Comment 6

[Simon Paquet [:sipaq]]

Based on the feedback I have received here, I'm marking this bug as WONTFIX for Thunderbird.