nanojit: avoid using ~allocator.free

RESOLVED FIXED

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

Trunk
x86
Linux
Points:
---
Bug Flags:
wanted1.9.2 +

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
We have evictRegs(~allocator.free) in several places in Assembler.cpp.  It means "evict all active registers" and works but is dodgy because 'free' and 'active' aren't complementary (there's a 3rd class of "unmanaged" registers).

Probably the best thing to do is to create evictActiveRegs().  It might even be slightly faster as it avoids the is-it-in-the-RegisterMask test for each register.
(Assignee)

Updated

9 years ago
Blocks: 513616
(Assignee)

Comment 1

9 years ago
Created attachment 399155 [details] [diff] [review]
patch
Attachment #399155 - Flags: review?(edwsmith)

Updated

9 years ago
Attachment #399155 - Flags: review?(edwsmith) → review+
(Assignee)

Comment 2

9 years ago
http://hg.mozilla.org/tracemonkey/rev/19b5d858f40c
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/19b5d858f40c
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 4

9 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/8f1ff70e6044
status1.9.2: --- → beta1-fixed
Flags: wanted1.9.2+
You need to log in before you can comment on or make changes to this bug.