Closed
Bug 514551
Opened 15 years ago
Closed 15 years ago
nanojit: avoid using ~allocator.free
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta1-fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
4.76 KB,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
We have evictRegs(~allocator.free) in several places in Assembler.cpp. It means "evict all active registers" and works but is dodgy because 'free' and 'active' aren't complementary (there's a 3rd class of "unmanaged" registers).
Probably the best thing to do is to create evictActiveRegs(). It might even be slightly faster as it avoids the is-it-in-the-RegisterMask test for each register.
![]() |
Assignee | |
Comment 1•15 years ago
|
||
Attachment #399155 -
Flags: review?(edwsmith)
Updated•15 years ago
|
Attachment #399155 -
Flags: review?(edwsmith) → review+
![]() |
Assignee | |
Comment 2•15 years ago
|
||
Whiteboard: fixed-in-tracemonkey
Comment 3•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 4•15 years ago
|
||
status1.9.2:
--- → beta1-fixed
Flags: wanted1.9.2+
You need to log in
before you can comment on or make changes to this bug.
Description
•