514625 - nanojit: kill AR::highwatermark

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

Attachment: patch

AR::highwatermark always has the same value as AR::tos.  You can see this because they're always assigned the same value at the same time.  This patch removes AR::highwatermark.

Comment 1

[Nicholas Nethercote [inactive]]

http://hg.mozilla.org/tracemonkey/rev/e1aa3e759819

Comment 2

[Andreas Gal :gal]

We should coordinate on these changes. I will have to back this out since it conflicts with my ESP-relative patch (I need highwatermark) and also conflicts with branch attaching without reloading.

Comment 3

[Nicholas Nethercote [inactive]]

(In reply to comment #2)
> We should coordinate on these changes. I will have to back this out since it
> conflicts with my ESP-relative patch (I need highwatermark)

Is that bug 473494?  If so, I don't think this patch causes problems -- I got rid of 'highwatermark' not because it wasn't used, but rather because it always had the same value as 'tos'.  I don't see anywhere in your patch where the two values would have cause to differ, so I think you can use replace all occurrences of 'highwatermark' with 'tos'.  (If you think 'highwatermark' is a better name than 'tos' I can understand that.)

> and also conflicts with branch attaching without reloading.

Which bug is that?

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/e1aa3e759819

Comment 5

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/31dbccbd0330

Comment 6

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/31dbccbd0330