bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

disable updating of Live Titles when Private Browsing is active

RESOLVED WORKSFORME

Status

()

Firefox
Private Browsing
RESOLVED WORKSFORME
9 years ago
2 years ago

People

(Reporter: mconnor, Assigned: Ehsan)

Tracking

(Depends on: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
If I use PB, all of my bookmarks with live titles get temporarily hosed.
(Assignee)

Comment 1

9 years ago
Could you please provide a bit more information on what happens here, and what is expected to happen?  I've never used bookmarks with live titles, so this might be obvious... :/
(Assignee)

Comment 2

9 years ago
If I'm not mistaken, Firefox stores microsummaries as Places annotations.  If that is the case, storing them fails inside the private browsing mode because of bug 509106.  Is this what this bug is about?
Depends on: 509106
(Reporter)

Comment 3

9 years ago
Bugzilla supports this for saved queries, if you need an example (bookmark, change the dropdown).  Since the microsummary relies on the cookie for the saved query to work, it returns useless data if you're in private browsing mode (and your cookie is no longer present).

http://mxr.mozilla.org/mozilla-central/source/browser/components/microsummaries/src/nsMicrosummaryService.js#262 calls setItemTitle when it refreshes.  We don't protect against that (for good reason) but we should simply cancel the timer (this._timer) on enter and restore it on exit.
(Assignee)

Comment 4

9 years ago
Created attachment 398869 [details] [diff] [review]
Patch (v1)

Does this make sense?
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #398869 - Flags: review?(mconnor)
(Reporter)

Comment 5

9 years ago
Comment on attachment 398869 [details] [diff] [review]
Patch (v1)

Yep, that works, except I don't know whether we should disable the manual update as well.  Thoughts?
(Assignee)

Comment 6

9 years ago
(In reply to comment #5)
> (From update of attachment 398869 [details] [diff] [review])
> Yep, that works, except I don't know whether we should disable the manual
> update as well.  Thoughts?

Well, based on comment 3 (the fact that we don't send out cookies in PB mode), what's the point of letting the users update them manually?
(Reporter)

Comment 7

9 years ago
Because not all sites with microsummaries require cookies (i.e. woot.com).  And because I'm not sure how this interacts with allowing users to bookmark in PB.
(Reporter)

Comment 8

9 years ago
Comment on attachment 398869 [details] [diff] [review]
Patch (v1)

Yeah, thought about this but failed to follow up.  We should just stop the automatic refreshes, and allow manual refreshing/updating.
Attachment #398869 - Flags: review?(mconnor) → review-

Comment 9

2 years ago
Microsummaries are dead, long live microsummaries.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.