514636 - disable updating of Live Titles when Private Browsing is active

Status: RESOLVED WORKSFORME

(Firefox :: Private Browsing, defect)

Description

[Mike Connor [:mconnor]]

If I use PB, all of my bookmarks with live titles get temporarily hosed.

Comment 1

[(no longer active)]

Could you please provide a bit more information on what happens here, and what is expected to happen?  I've never used bookmarks with live titles, so this might be obvious... :/

Comment 2

[(no longer active)]

If I'm not mistaken, Firefox stores microsummaries as Places annotations.  If that is the case, storing them fails inside the private browsing mode because of bug 509106.  Is this what this bug is about?

Comment 3

[Mike Connor [:mconnor]]

Bugzilla supports this for saved queries, if you need an example (bookmark, change the dropdown).  Since the microsummary relies on the cookie for the saved query to work, it returns useless data if you're in private browsing mode (and your cookie is no longer present).

http://mxr.mozilla.org/mozilla-central/source/browser/components/microsummaries/src/nsMicrosummaryService.js#262 calls setItemTitle when it refreshes.  We don't protect against that (for good reason) but we should simply cancel the timer (this._timer) on enter and restore it on exit.

Comment 4

[(no longer active)]

Attachment: Patch (v1)

Does this make sense?

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 398869 [details] [diff] [review]
Patch (v1)

Yep, that works, except I don't know whether we should disable the manual update as well.  Thoughts?

Comment 6

[(no longer active)]

(In reply to comment #5)
> (From update of attachment 398869 [details] [diff] [review])
> Yep, that works, except I don't know whether we should disable the manual
> update as well.  Thoughts?

Well, based on comment 3 (the fact that we don't send out cookies in PB mode), what's the point of letting the users update them manually?

Comment 7

[Mike Connor [:mconnor]]

Because not all sites with microsummaries require cookies (i.e. woot.com).  And because I'm not sure how this interacts with allowing users to bookmark in PB.

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 398869 [details] [diff] [review]
Patch (v1)

Yeah, thought about this but failed to follow up.  We should just stop the automatic refreshes, and allow manual refreshing/updating.

Comment 9

[:Gijs (he/him)]

Microsummaries are dead, long live microsummaries.