Let Mochitest run on IE

RESOLVED FIXED in mozilla1.9.3a1

Status

Testing
Mochitest
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Sylvain Pasche, Assigned: Sylvain Pasche)

Tracking

Trunk
mozilla1.9.3a1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed1.9.2b1 fixed1.9.1.4])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

8 years ago
Created attachment 398655 [details] [diff] [review]
use var instead of const.

A const slipped in SimpleTest.js from bug 494397.
Attachment #398655 - Flags: review?(sayrer)

Updated

8 years ago
Attachment #398655 - Flags: review?(sayrer) → review+
Comment on attachment 398655 [details] [diff] [review]
use var instead of const.


It looks like you did not prepare this patch against m-c trunk...

Please, add a comment about this at the top of the file.
(Assignee)

Comment 2

8 years ago
Created attachment 398669 [details] [diff] [review]
use var instead of const, v2

(In reply to comment #1)
> (From update of attachment 398655 [details] [diff] [review])
> 
> It looks like you did not prepare this patch against m-c trunk...

oops, yeah my tree was a few days old.

> Please, add a comment about this at the top of the file.

How does this sound?

+ * NOTE: Pay attention to cross-browser compatibility in this file. For
+ * instance, do not use const or JS > 1.5 features which are not yet
+ * implemented everywhere.
+ *
Assignee: nobody → sylvain.pasche
Attachment #398655 - Attachment is obsolete: true
Status: NEW → ASSIGNED
(In reply to comment #2)

> How does this sound?
> 
> + * NOTE: Pay attention to cross-browser compatibility in this file. For
> + * instance, do not use const or JS > 1.5 features which are not yet
> + * implemented everywhere.
> + *

That should be just fine.

(NB: Though now I wonder about the other files: in SimpleTest/, and all our tests.
Maybe we will see about this when we start to upstream our changes to MochiKit...)
(Assignee)

Comment 4

8 years ago
Yeah, there may be some issues in the other files. If I open http://localhost:8000/tests and click "Run Tests", there's an exception in IE.
Keywords: checkin-needed
Oh :-( Which exception?

Then I would suggest to fix all SimpleTest/* at the same time...
(Assignee)

Comment 6

8 years ago
Message: 'undefined' is null or not an object
Line: 3027
Char: 1
Code: 0
URI: http://localhost:8888/MochiKit/packed.js


ok, I can try to find the issue and maybe do a single patch.
(Assignee)

Comment 7

8 years ago
Created attachment 399598 [details] [diff] [review]
patch, v2
[Checkin: Comment 8 & 9 & 10]

Two more things:
- fallback to testFrame.contentWindow.document if testFrame.contentDocument is unavailable
- innerHTML instead of textContent

With that the harness should be able to run tests on IE 8.
Attachment #398669 - Attachment is obsolete: true
Attachment #399598 - Flags: review?(sayrer)

Updated

8 years ago
Attachment #399598 - Flags: review?(sayrer) → review+
Comment on attachment 399598 [details] [diff] [review]
patch, v2
[Checkin: Comment 8 & 9 & 10]


http://hg.mozilla.org/mozilla-central/rev/62f6012a7e6c
Attachment #399598 - Attachment description: patch, v2 → patch, v2 [Checkin: Comment 8]
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [c-n: m-1.9.2, m-1.9.1]
Target Milestone: --- → mozilla1.9.3a1
Comment on attachment 399598 [details] [diff] [review]
patch, v2
[Checkin: Comment 8 & 9 & 10]


http://hg.mozilla.org/releases/mozilla-1.9.2/rev/631b49078b78
Attachment #399598 - Attachment description: patch, v2 [Checkin: Comment 8] → patch, v2 [Checkin: Comment 8 & 9]
Whiteboard: [c-n: m-1.9.2, m-1.9.1] → [c-n: m-1.9.1]
Whiteboard: [c-n: m-1.9.1] → [c-n: m-1.9.1] [fixed1.9.2b1]
Comment on attachment 399598 [details] [diff] [review]
patch, v2
[Checkin: Comment 8 & 9 & 10]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/db61be37d6c7
Attachment #399598 - Attachment description: patch, v2 [Checkin: Comment 8 & 9] → patch, v2 [Checkin: Comment 8 & 9 & 10]
Keywords: checkin-needed
Whiteboard: [c-n: m-1.9.1] [fixed1.9.2b1] → [fixed1.9.2b1 fixed1.9.1.4]
You need to log in before you can comment on or make changes to this bug.