514696 - [mozmill] testIdentityPopupOpenClose.js fails due to focus issues

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch

Executing the test below will cause a timout when waiting for the identity popup. The error only applies when you run all the security tests. Running the test alone doesn't show this problem.

Test Failed : testIdentityPopupOpenClose in c:\mozilla\tests\firefox\testSecurit
y\testIdentityPopupOpenClose.js

ERROR - Test Failure: {'exception': {'message': "timeout exceeded for waitForEva
l('subject.state == 'open'')", 'lineNumber': 300, 'stack': 'Error("timeout excee

I checked why the combination of tests is causing this timeout and I have noticed that our tests are too fast. Especially the grey larry one which gets run right before. The last action in this test is to close the page info window. Directly after we click in the next test on the identity popup box.

We have to wait a bit so the page info window can close until the next test is started. We do not suffer from the problem if such actions are used inside a test itself. It only happens for several test modules.

Eventually we should create a helper class for additional non-modal windows too.

Comment 1

[Aakash Desai [:aakashd]]

Comment on attachment 398688 [details] [diff] [review]
Patch

Looks good on my end and will remember to add these sleeps from now on. Also, I'd like to mention that this will need to be added for passwordManager and cookieManager testscripts.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Those sleeps aren't necessary all the time but until we have a better way to wait for the closing of the window we should add a sleep.

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/ddbd4a9286ec
http://hg.mozilla.org/qa/mozmill-tests/rev/c2f933bd5702

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.