Closed
Bug 514722
Opened 15 years ago
Closed 15 years ago
Remove unneeded buildid directory
Categories
(Firefox Build System :: General, defect)
Tracking
(status1.9.2 beta1-fixed, status1.9.1 .4-fixed)
RESOLVED
FIXED
mozilla3.7a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta1-fixed |
status1.9.1 | --- | .4-fixed |
People
(Reporter: jhford, Assigned: jhford)
References
Details
Attachments
(1 file)
462 bytes,
patch
|
ted
:
review+
ted
:
approval1.9.2+
dveditz
:
approval1.9.1.4+
|
Details | Diff | Splinter Review |
There is a directory (http://hg.mozilla.org/mozilla-central/annotate/64da35bd0d16//Makefile.in#l196) that is created. Up until now, these directories were inside the builder directory in our buildbot configs. We are changing how buildbot manages source code and as a result these directories will start building up in places where they will not get deleted. Apparently it is a left over directory. This patch removes this directory. A simple search of MXR "$(topsrcdir)/../$(BUILDID)" and "../$(BUILDID)" show that the directory is only referenced in the Makefile.in that I am patching. If this directory is in fact needed, would we be able to move it to somewhere in the objdir? It would be ideal if it were landed on the branches.
Attachment #398715 -
Flags: review?(ted.mielczarek)
Comment 1•15 years ago
|
||
Comment on attachment 398715 [details] [diff] [review] remove undeeded directory Leftover, doesn't actually do anything. I forgot to delete it when I fixed bug 478221. You'll need separate approval for 1.9.1, but I can't grant that.
Attachment #398715 -
Flags: review?(ted.mielczarek)
Attachment #398715 -
Flags: review+
Attachment #398715 -
Flags: approval1.9.2+
Attachment #398715 -
Flags: approval1.9.1.4?
Updated•15 years ago
|
Attachment #398715 -
Flags: approval1.9.1.4? → approval1.9.1.4+
Comment 2•15 years ago
|
||
Comment on attachment 398715 [details] [diff] [review] remove undeeded directory Not sure we care, but Approved for 1.9.1.4, a=dveditz for release-drivers
Updated•15 years ago
|
Keywords: checkin-needed
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/b75ece26a9c1
Assignee: nobody → jford
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Updated•15 years ago
|
Keywords: checkin-needed
Updated•15 years ago
|
Keywords: checkin-needed
Whiteboard: [needs 1.9.1 and 1.9.2 branch landing]
Comment 4•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/c5e339ec8304 http://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml
status1.9.1:
--- → .4-fixed
status1.9.2:
--- → beta1-fixed
Whiteboard: [needs 1.9.1 and 1.9.2 branch landing]
Comment 5•15 years ago
|
||
> http://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml Guess you mean http://hg.mozilla.org/releases/mozilla-1.9.1/rev/cad3aa708b4e :)
Keywords: checkin-needed
Comment 6•15 years ago
|
||
Uh, yeah. :)
Updated•14 years ago
|
Flags: in-testsuite-
Updated•5 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
Updated•5 years ago
|
Target Milestone: Firefox 3.7a1 → mozilla3.7a1
You need to log in
before you can comment on or make changes to this bug.
Description
•