514807 - [HTML5] Tinderbox leaks nsGenericElement+ with html5.enable true

Status: VERIFIED WORKSFORME

(Core :: DOM: HTML Parser, defect, P1)

Description

[Jesse Ruderman]

Loading http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox leaks nsGenericElement and more (as shown by trace-refcnt), but only if html5.enable is true.

Comment 1

[Henri Sivonen (:hsivonen)]

I don't see the leak anymore with my patch queue applied, but NS_LogAddRef_P asserts a lot:
      NS_ASSERTION(serialno != 0,
                   "Serial number requested for unrecognized pointer!  "
                   "Are you memmoving a refcounted object?");

Comment 2

[Henri Sivonen (:hsivonen)]

Also leaked when nsGenericElement leaks:

  89 nsHtml5AttributeName                           16     9296      581      581 (  291.00 +/-   167.86)        0        0 (    0.00 +/-     0.00)
  90 nsHtml5ElementName                             28    10948      391      391 (  196.00 +/-   113.02)        0        0 (    0.00 +/-     0.00)
  91 nsHtml5HtmlAttributes                          24       24        1        1 (    1.00 +/-     0.00)        0        0 (    0.00 +/-     0.00)

Which looks like nsHtml5Module never gets a shutdown call, which would mean the layout module isn't shutting down properly.

Comment 3

[Henri Sivonen (:hsivonen)]

Marking WFM per comment #1, since the assertions fire with the old parser, too (filed as bug 548258).

Comment 4

[Jesse Ruderman]

WFM, no leak on trunk with html5.enable true.