514829 - [gnomestripe] the old style folder icons are used in a number of places (those where folder.png is referred to)

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

There are some places where the tb2 folder icons are still used. 

 - all move/copy to menus
 - the offline selection dialog (Click Advanced... in the imap synch settings)
 - imap/nntp subscription dialog
 - feed subscription dialog

Also, the filter dialog lacks icons totally for when selecting action target folders. (Requesting sr for this one-liner.)

Qute may need some of these fixes too, (especially msgSelectOffline.css should be easy to fix), but as i can't test it anyway, lets keep this to be about gnomestripe.

I notice archives (and outbox where applicable) special folder icons don't get set for the offline dialog, filter move to folder, although they are correct in folderMenus.css since it works in the move/copy menus. I'll file a new bug about that if there isn't one already.

Comment 1

[Magnus Melin [:mkmelin]]

Note to self: server.png should also go (in a separate bug), just the nntp server icons are used and should be moved to folder-pane.png

Which reminds me, the patch also fixes the look of saved searches with unseen messages. That was still using the old red star, that it actually worked out reasonably with the old folder icons peeking from behind seemed coincidental...

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2

Unbitrot myself

Comment 3

[Magnus Melin [:mkmelin]]

(also hg remove mail/themes/gnomestripe/mail/icons/folder.png - forgot to re-include that, fixed locally)

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 399308 [details] [diff] [review]
proposed fix, v2

sr+a=Standard8.

I think this should be safe to land for b4 as well (mainly being theme based).

Comment 5

[Magnus Melin [:mkmelin]]

changeset:   3602:806cadd87cb3
http://hg.mozilla.org/comm-central/rev/806cadd87cb3

->FIXED

Filed bug 515377 about the missing archives icon in the offline dialog.