Find does not match characters beyond first non-matching character after FAYT failure

VERIFIED FIXED in mozilla1.9.3a1

Status

()

Toolkit
Find Toolbar
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: IU, Assigned: vlad)

Tracking

({regression})

Trunk
mozilla1.9.3a1
regression
Points:
---

Firefox Tracking Flags

(status1.9.2 beta2-fixed)

Details

Attachments

(3 attachments)

(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090905 Minefield/3.7a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090905 Minefield/3.7a1pre ID:20090905041935

If you search for the word "filter" in a page that can match only "fi", subsequent matches using <F3> will only match "fil" (i.e. up to and including the first non-matching character, but no further).  This in spite of the fact that the original word "filter" is what shows up on Edit --> Find.

Regression:
Works: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090902 Minefield/3.7a1pre
Fails: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090903 Minefield/3.7a1pre


Reproducible: Always

Steps to Reproduce:
FOLLOW STEPS EXACTLY

1. Open attached test case "test case: Page 1"
2. Perform FAYT by typing /filter (i.e. quick find "filter"). Nothing will be found
3. You should notice that Step 2 matched "fi", but stops matching with "fil" (i.e. no matches after "fi")
4. Open attached test case "test case: Page 2"
5. Press <F3>.  Notice that "fil" is matched -- even though "filter" was typed.
6. Click Edit --> Find.  Notice that "filter" is the find string.
(Reporter)

Comment 1

9 years ago
Created attachment 398863 [details]
test case: Page 1
(Reporter)

Comment 2

9 years ago
Created attachment 398864 [details]
test case: Page 2
(Reporter)

Updated

9 years ago
Blocks: 512643
Keywords: regression
Version: unspecified → Trunk
(Reporter)

Updated

9 years ago
Component: Find Backend → Find Toolbar
Product: Core → Toolkit
Ah whoops, we need to reset the optimization when the find bar is opened again.  I'll fix.
Assignee: nobody → vladimir
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: find-backend → fast.find
I think this can be solved by just removing the !this.hidden check in onFindAgainCommand.
Attachment #402155 - Flags: review? → review?(gavin.sharp)
Attachment #402155 - Flags: review?(gavin.sharp) → review+
(Reporter)

Updated

9 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/81c631e0143f
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
(Reporter)

Comment 7

9 years ago
Verified fixed.  Thanks.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090927 Minefield/3.7a1pre ID:20090927045524
Status: RESOLVED → VERIFIED
status1.9.2: --- → final-fixed
You need to log in before you can comment on or make changes to this bug.