Closed
Bug 514920
Opened 15 years ago
Closed 15 years ago
Add-ons manager opened for add-on install has no pane selector
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | unaffected |
status1.9.1 | --- | unaffected |
People
(Reporter: mossop, Assigned: mossop)
References
Details
Attachments
(2 files)
30.71 KB,
image/png
|
Details | |
796 bytes,
patch
|
dveditz
:
review+
|
Details | Diff | Splinter Review |
When the add-ons manager opens to show an add-on download on current trunk the pane selector is not visible. When hidden: chromehidden="menubar toolbar location directories status extrachrome" When not hidden: chromehidden="location directories status extrachrome "
Assignee | ||
Comment 1•15 years ago
|
||
screenshot of the problem
Assignee | ||
Comment 2•15 years ago
|
||
nsXPInstallManager.cpp isn't passing the full set of window flags, previously this was masked by bug 509124. http://mxr.mozilla.org/mozilla/source/xpinstall/src/nsXPInstallManager.cpp#539
Updated•15 years ago
|
blocking2.0: --- → ?
Comment 3•15 years ago
|
||
Neil, it looks like your assumption on bug 509124 comment 12 wasn't correct. I searched MXR and there are even more parent-less windows listed. Which of them could be involved too? http://mxr.mozilla.org/mozilla-central/search?string=OpenWindow%280, http://mxr.mozilla.org/mozilla-central/search?string=OpenWindow%28null,
OS: Mac OS X → All
Hardware: x86 → All
Comment 4•15 years ago
|
||
(In reply to comment #3) > Neil, it looks like your assumption on bug 509124 comment 12 wasn't correct. I > searched MXR and there are even more parent-less windows listed. Which of them > could be involved too? The ones that include "all" in their window features definitely are not affected, as this is what they used to get anyway. The rest would only be affected if they have hideable chrome, which most windows don't.
Assignee | ||
Comment 5•15 years ago
|
||
This syncs up the features that xpinstall launches the progress dialog with with those we use for the extension manager.
Comment 6•15 years ago
|
||
Comment on attachment 399435 [details] [diff] [review] patch rev 1 r=dveditz
Attachment #399435 -
Flags: review?(dveditz) → review+
Assignee | ||
Comment 7•15 years ago
|
||
I'm not likely to get chance to land this till next week
Keywords: checkin-needed
Comment 8•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/74846acee4af
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Assignee | ||
Updated•15 years ago
|
status1.9.1:
--- → unaffected
status1.9.2:
--- → unaffected
Updated•14 years ago
|
blocking2.0: ? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•