Closed Bug 514954 Opened 15 years ago Closed 15 years ago

add AC_DEFINE for official-branding

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(status1.9.2 beta1-fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a1
Tracking Flags:
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

Attachments

(1 file, 1 obsolete file)

review comment addressed
1.92 KB, patch
pavlov
: approval1.9.2+
Details | Diff | Splinter Review 
So that apps can easily make build-time decisions based on branding (see dependent bugs).
Attached patch patch (obsolete) — — Splinter Review 
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED

        Attachment #398964 -
        Flags: review?(ted.mielczarek)

    
    

    
  
Comment on attachment 398964 [details] [diff] [review]
patch

+AC_SUBST(MOZ_OFFICIAL_BRANDING)

If you're going to AC_SUBST, you need to add a matching line in config/autoconf.mk.in.

        Attachment #398964 -
        Flags: review?(ted.mielczarek) → review+

    
    

    
  
Comment on attachment 398964 [details] [diff] [review]
patch

needed on 1.9.2 for fennec

        Attachment #398964 -
        Flags: approval1.9.2?

    
    

    
  


  

        Attachment #398964 -
        Attachment is obsolete: true

        Attachment #398992 -
        Flags: approval1.9.2?

        Attachment #398964 -
        Flags: approval1.9.2?

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/8dbe8de92cb4
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2b1
Blocks: 515009

    
  

        Attachment #398992 -
        Flags: approval1.9.2? → approval1.9.2+
Flags: in-testsuite-
Target Milestone: mozilla1.9.2b1 → mozilla1.9.3a1
Blocks: 554359
No longer blocks: 515009

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: