Closed Bug 514974 Opened 15 years ago Closed 15 years ago

Read after free in nptest.cpp

Categories

(Core Graveyard :: Plug-ins, defect)

x86
macOS
defect
Not set
normal

Tracking

(status1.9.2 beta1-fixed)

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: roc, Assigned: roc)

Details

Attachments

(1 file)

Attached patch fixSplinter Review
Julian Seward noticed that NPP_Destroy reads via instanceData after we've freed it.
Attachment #398988 - Flags: review?(joshmoz)
Attachment #398988 - Flags: review?(joshmoz) → review+
Comment on attachment 398988 [details] [diff] [review]
fix

Ha, I was just about to post this patch.
http://hg.mozilla.org/mozilla-central/rev/68762e0a8a56
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment on attachment 398988 [details] [diff] [review]
fix

We should take this trivial memory safety fix on branch
Attachment #398988 - Flags: approval1.9.2?
Attachment #398988 - Flags: approval1.9.2? → approval1.9.2+
Whiteboard: [needs 192 landing]
Looks like jgriffin checked in an analogous fix in http://hg.mozilla.org/releases/mozilla-1.9.2/rev/0bbcf751c0a6 

Marking status1.9.2 = beta1fixed. Please reopen if you disagree.
Whiteboard: [needs 192 landing]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: