515021 - Cannot rename virtual Search Folder under News server account

Status: ASSIGNED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Jesse Houwing]

Attachment: Screenshot showing the Search Folder setup

I created a virtual Search folder under my news group account. This search is shown at the bottom of the folder tree. I'd like it to be on top. I tried renaming the folder, but the Rename option does not accept any proposed value.

Steps to reproduce:
- Click on the news server
- Hit ctrl-shift-f
- create a search and save as search folder (choose the newsserver as parent)
- Notice that the search foler appears on the top of the list (see bug https://bugzilla.mozilla.org/show_bug.cgi?id=506520)
- restart thunderbird
- right-click the Search Folder and choose rename
- enter any value
- click Rename

Expected:
- Folder is renamed or an error message is shown telling me why my proposed name was rejected

Actual result:
- Nothing happens.

Comment 1

[Magnus Melin [:mkmelin]]

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIMsgFolder.rename]"  nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame :: chrome://messenger/content/folderPane.js :: renameCallback :: line 1743"  data: no]

Comment 2

[David :Bienvenu]

not blocking, but wanted. There are a whole host of bugs having to do with saved searches under news folders, having to do with the fact that we're paying attention to news folder capabilities which don't apply to saved searches (e.g., rename).

Comment 4

[:aceman]

Attachment: patch

Comment 5

[Joshua Cranmer [:jcranmer]]

Comment on attachment 715774 [details] [diff] [review]
patch

Review of attachment 715774 [details] [diff] [review]:
-----------------------------------------------------------------

Pursuant to the comments in bug 272490, I don't think this is desirable right now.

Comment 6

[:aceman]

Attachment: patch - hide Rename option

So would you accept a patch that hides the Rename item in the context menu while it is not working?

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 8362718 [details] [diff] [review]
patch - hide Rename option

Review of attachment 8362718 [details] [diff] [review]:
-----------------------------------------------------------------

I suppose, but do add a comment about why. 
Personally, I'd prefer to go with the earlier patch though. From an end user perspective that's what we want, and in the end that's all that matters.

Comment 8

[:aceman]

Yeah, I would like it too, but it didn't pass through jcranmer.

Comment 9

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8362718 [details] [diff] [review]
patch - hide Rename option

Review of attachment 8362718 [details] [diff] [review]:
-----------------------------------------------------------------

I know I've been avoiding this patch for a while.

I think you misunderstood the direction I wanted to drag virtual folders and NNTP in: this is only making it worse (although subtly so).

The main problem is that I don't want nsMsgNewsFolder--or nsIMsgNewsFolder in IDL terms--to implement a virtual folder. The obvious solution to this conundrum is to divorce the definition of a newsgroup based not on folder.server.type but rather on folder instanceof (or, better yet, folder capabilities instead of instanceof checks). I do realize it's not idiomatic, but I think lives would be easier if we started making it so.

Comment 10

[Joshua Cranmer [:jcranmer]]

(And, fwiw, a more useful use of time would be not trying to patch over failures but figuring out how to make NNTP servers not use nsMsgNewsFolder for implementations of virtual folders rather than trying to patch individual pain points).