515028 - fix openPopupAtScreen idl comment to reflect the fact that coordinates are in absolute screen space

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Dão Gottwald [:dao]]

see bug 514891 comment 7

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

I guess I need an sr here since this is technically an API change.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 399109 [details] [diff] [review]
patch

Looks ok, but maybe explictly say the coordinates are in absolute screen space?

Comment 3

[Timothy Nikkel (:tnikkel)]

Comment on attachment 399109 [details] [diff] [review]
patch

We should take this on 1.9.2 because 1.9.2 changed the behaviour of openPopupAtScreen due to bug 393186. The coordinates have always been in absolute screen space, but before bug 393186 we would constrain to the active screen.

Comment 4

[Timothy Nikkel (:tnikkel)]

Per Boris' comment, I changed the comment to say
   * Open the popup at a specific screen position specified by x and y. This
   * position may be adjusted if it would cause the popup to be off of the
   * screen. The x and y coordinates are measured in CSS pixels, and like all
   * screen coordinates, are given relative to the top left of the primary
   * screen.

Comment 5

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/mozilla-central/rev/841ec7492ecb

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 399109 [details] [diff] [review]
patch

I think it's too late to take the UUID change on 1.9.2 at this point. We could take just the comment change, though...