515098 - PlayAudio() in nsOggDecodeStateMachine::QueueDecodedFrames()

Status: RESOLVED DUPLICATE of bug 506061

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We should call PlayAudio() in nsOggDecodeStateMachine::QueueDecodedFrames(). This means that on Linux we're less likely to get into the situation where the nsAudioStream doesn't advance because the underlying hardware underruns or otherwise doesn't have enough data to advance its hardware clock to the end of a frame.

Comment 1

[cajbir (:cajbir)]

See bug 506061 comment 27 for my thoughts.

Comment 2

[Matthew Gregan [:kinetik]]

I'm already working on this...

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Progress so far... Doesn't change buffering.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

We can wait for Matt's patch for this.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to comment #3)
> Created an attachment (id=399135) [details]
> Patch

This patch regresses bug 506434, because it removes the hasAudio condition in PlayFrame(). I removed it because no frame has audio data by that point; it's already been pushed to the hardware, so we would have always using the system clock to sync sound.