Remove unused method nsHTMLSelectElement::DispatchDOMEvent

RESOLVED FIXED

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
The method "nsHTMLSelectElement::DispatchDOMEvent" causes a build warning because it hides an inherited method:
> /mozilla/content/html/content/src/../../../base/src/nsGenericElement.h:363: warning: ‘virtual nsresult nsGenericElement::DispatchDOMEvent(nsEvent*, nsIDOMEvent*, nsPresContext*, nsEventStatus*)’ was hidden
> mozilla/content/html/content/src/nsHTMLSelectElement.h:450: warning:   by ‘void nsHTMLSelectElement::DispatchDOMEvent(const nsAString_internal&)’

In fact, the method isn't actually used anymore -- its last use was removed in the first patch for bug 430214 -- http://hg.mozilla.org/mozilla-central/rev/36a1bd4eedfc  (Furthermore, it looks like just a simple one-liner convenience method -- doesn't do anything special.)

Filing this bug on deleting the method.
(Assignee)

Comment 1

9 years ago
Created attachment 399287 [details] [diff] [review]
fix
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #399287 - Flags: review?(Olli.Pettay)
(Assignee)

Updated

9 years ago
Hardware: x86 → All

Updated

9 years ago
Attachment #399287 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Comment 2

9 years ago
landed: http://hg.mozilla.org/mozilla-central/rev/bb314eede151
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.