515365 - IPDL: code generation wrong passing a protocol as a parameter

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Benjamin Smedberg]

When passing another protocol as a parameter, the code generation is wrong: it's passing around PStreamNotify as a c++ type instead of PStreamNotifyParent/Child pointers/references.

PPluginInstanceProtocol.h:

class Msg_PBrowserStreamConstructor :
    public IPC::Message
{
private:

public:
    enum {
        ID = Msg_PBrowserStreamConstructor__ID
    };
    Msg_PBrowserStreamConstructor(
            const nsCString& url,
            const uint32_t& length,
            const uint32_t& lastmodified,
            const PStreamNotify& notifyData,
            const nsCString& headers,
            const nsCString& mimeType,
            const bool& seekable,
            const mozilla::ipc::ActorHandle& __ah) :

Comment 1

[Benjamin Smedberg]

Attachment: Current WIP patch

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Pushed http://hg.mozilla.org/projects/electrolysis/rev/6cc76fc77a13.

Again, there's a bug in a C++ concrete class preventing this patch from compiling, so I'm not sure it's 100% right.  Please reopen if not.